Closed Bug 1794653 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36400 - Fix a bug in "hide all popups until" algorithm

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36400 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36400
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Fix a bug in "hide all popups until" algorithm

Previously, if a "popuphide" event handler hid the final target
of the "hide all popups until" algorithm, that algorithm would
incorrectly hide all open pop-ups. With this change, that no
longer happens.

Bug: 1307772
Change-Id: If2ca4c0dff0c649dcb871067f7fd8f58e3b94039
Reviewed-on: https://chromium-review.googlesource.com/3940344
WPT-Export-Revision: 25daed43b1a26b37d29d3b7394776ea4bb79ab1d

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 25 subtests

Status Summary

Firefox

FAIL : 23
ERROR: 1

Chrome

OK : 1
PASS : 21
FAIL : 4

Safari

FAIL : 23
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-light-dismiss.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Clicking outside a popup will dismiss the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Clicking inside a popup does not close that popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Pop-ups close on mouseup, not mousedown: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus outside the popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a child popup shouldn't close either popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a parent popup should close child popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Clicking on invoking element, after using it for activation, shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on invoking element, after using it for activation, shouldn't close its popup (nested case): FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on invoking element, after using it for activation, shouldn't close its popup (nested case, not used for invocation): FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on invoking element, even if it wasn't used for activation, shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on popuptoggletarget element, even if it wasn't used for activation, should hide it exactly once: FAIL (Chrome: FAIL, Safari: FAIL)
    • Clicking on anchor element (that isn't an invoking element) shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Dragging from an open popup outside an open popup should leave the popup open: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element should be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element that was not used to invoke the popup can still be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • Scrolling within a popup should not close the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Moving focus back to the anchor element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to the active trigger element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to an inactive trigger element should also not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional, with a direct showPopUp(): FAIL (Chrome: PASS, Safari: FAIL)
    • Light dismiss of mixed popup types: FAIL (Chrome: PASS, Safari: FAIL)
    • Hide the target pop-up during "hide all popups until": FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcf728ebcaea [wpt PR 36400] - Fix a bug in "hide all popups until" algorithm, a=testonly https://hg.mozilla.org/integration/autoland/rev/5226bf12bc7e [wpt PR 36400] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/bcf728ebcaea
https://hg.mozilla.org/mozilla-central/rev/5226bf12bc7e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.