1794722 - WebRender driver block list on Linux needs to be refactored to allow by default

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Ashley Hale [:ahale]]

As much as possible we should be giving Linux users the happy path of fast WebRender, so we should change the block list to an allow by default policy, rather than enabling each piece of hardware only on request (e.g. bug #1791970).

Changing to an allow by default policy will likely reveal some broken configurations out there, so this may involve multiple attempts to get it right.

A second factor is that users who previously encountered graphics bugs may have been automatically punted to software WebRender and we need to put their prefs back to accelerated by default, as this is not a setting that is obvious to users and may simply lead to the perception that Firefox is slow, long after the underlying driver bugs were fixed.

Comment 1

[Ashley Hale [:ahale]]

NI - I'd like to know more about any major quirks in this block list code to minimize breakage when changing it to allow by default, thanks :)

Comment 2

[Ashley Hale [:ahale]]

https://searchfox.org/mozilla-central/rev/f118dae98073bc17efb8604a32abfcb7b4e05880/widget/gtk/GfxInfo.cpp#629 is the relevant function I am looking at. It's a bit unclear to me how this is evaluated, as it looks like a series of conditions with unknown precedence.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

I'm putting this together. There are lots of things to adjust, add and rip out.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1794722 - Part 1. Remove WebRender from the GfxInfo allowlist.

WebRender is a mature feature. We should start blocking it on known bad
devices over allowlisting known good devices. This may enable WebRender
in a few more obscure places than we shipped before.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1794722 - Part 2. Remove all uses of gfxVars::UseWebRender().

This is always true.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1794722 - Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled.

This is always true.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0093f071f1a5
Part 1. Remove WebRender from the GfxInfo allowlist. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/d7805be9dfb3
Part 2. Remove all uses of gfxVars::UseWebRender(). r=jrmuizel,media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/0217af5b1aa6
Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled. r=jrmuizel,webcompat-reviewers,twisniewski

Comment 8

[Cristian Tuns]

Backed out for causing multiple failures on RemoteProcessMonitor

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | RemoteProcessMonitor | application crashed [@ mozilla::gfx::gfxConfigManager::ConfigureFromBlocklist(long, mozilla::gfx::FeatureState*)]

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

I forgot to update the status code for WR on Android:
https://treeherder.mozilla.org/jobs?repo=try&revision=e262f50db7aa9ee098aa4e6501e449da1ac398e5

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0dd55319351
Part 1. Remove WebRender from the GfxInfo allowlist. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f518d5630dee
Part 2. Remove all uses of gfxVars::UseWebRender(). r=jrmuizel,media-playback-reviewers,alwu
https://hg.mozilla.org/integration/autoland/rev/adbac17a6db3
Part 3. Remove all uses of GfxInfo::GetWebRenderEnabled. r=jrmuizel,webcompat-reviewers,twisniewski

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f0dd55319351
https://hg.mozilla.org/mozilla-central/rev/f518d5630dee
https://hg.mozilla.org/mozilla-central/rev/adbac17a6db3