1794823 - Port site specific search from pine to central

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Hanna Jones [:hjones]]

As part of the pine work the Service Integrations team built out a contextual search/site specific search Urlbar result that allows the user to quickly execute a search via the search engine from the active page, provided the site utilizes OpenSearch.

The code for this feature contains nothing pine specific, so this seems like a good candidate for a feature we could easily port over to central.

This bug covers the initial work involved in getting the basic feature working on central behind a pref. From there, we can get more feedback from engineers/product managers with more urlbar domain knowledge and decide on next steps.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1794823 - port site specific search from pine to central r=daleharvey

Some random thoughts:

• This is a minimal implementation - there were plans to expand this with autocomplete support that we never got around to
• I built this just from reading docs + poking around in the urlbar code, so there might be a more desireable way to do all of this
• We've gone back and forth between calling this "contextual search" and "site specific search," we should probably pick a name and stick to it
• There were never any design specs for this so the UI/UX was based off of existing urlbar results as they appeared in Flowstate
• There were some open questions around how we treat installing opensearch engines, since how they are handled here seems to differ from how we use them elsewhere
• I don't remember the reasoning for showing this result last in the urlbar, we may want to move it elsewhere

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd22ddbe3fe
port site specific search from pine to central r=daleharvey

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9fd22ddbe3fe