Closed
Bug 1794943
Opened 2 years ago
Closed 2 years ago
[wpt-sync] Sync PR 35643 - Report the time of a video's first displayed frame for LCP
Categories
(Testing :: web-platform-tests, task, P4)
Testing
web-platform-tests
Tracking
(firefox108 fixed)
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 35643 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/35643
Details from upstream follow.
Ian Clelland <iclelland@chromium.org> wrote:
Report the time of a video's first displayed frame for LCP
This CL plumbs the information needed to capture LCP from videos
into Video timing information for LCP into the HTMLVideoElement, from
where it is sent to the PaintTimingDetector when the initial frame is
displayed.Video byte size is taken from the WebMediaPlayer's PipelineStatistics,
while the result of the Timing-Allow-Origin check goes through URLIndex,
in the same manner as CORS checks.Bug: 1289664
Change-Id: I9e8ed63a2913d5dc70b0f1b2bf9f928db4f1b908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814106
Commit-Queue: Ian Clelland \<iclelland@chromium.org>
Reviewed-by: Yoav Weiss \<yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1058088}
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dc46bc58b178954648128628a7821cdcfa461dc
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4be5505d0b7feb211662ba922f612038a023ba3d
|
|
Assignee | |
Comment 3•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 33 tests and 1 subtests
Status Summary
Firefox
OK : 26[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 31[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
CRASH : 1
FAIL : 26[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 31[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
TIMEOUT: 4
ERROR : 2
Chrome
OK : 32
PASS : 31
FAIL : 10
TIMEOUT: 2
Safari
OK : 31
FAIL : 31
ERROR : 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Crashes
- /largest-contentful-paint/video-poster.html [wpt.fyi]:
CRASH[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview],OK[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows10-32-2004-qr-debug,Gecko-windows10-32-2004-qr-opt,Gecko-windows10-64-2004-qr-debug,Gecko-windows10-64-2004-qr-opt,GitHub] linked bug:Bug 1794978
New Tests That Don't Pass
- /largest-contentful-paint/animated/observe-animated-image-gif.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/animated/observe-animated-image-webp.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/animated/observe-animated-image.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/animated/observe-cross-origin-animated-image.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/animated/observe-cross-origin-tao-animated-image.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/animated/observe-non-animated-image.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:FAIL, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/animated/observe-video.tentative.html [wpt.fyi]
- Same origin animated image is observable and has a first frame.:
FAIL(Chrome:TIMEOUT, Safari:FAIL)
- Same origin animated image is observable and has a first frame.:
- /largest-contentful-paint/contracted-image.html [wpt.fyi]
- Largest Contentful Paint: |size| attribute is bounded by display size.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: |size| attribute is bounded by display size.:
- /largest-contentful-paint/cross-origin-image.sub.html [wpt.fyi]
- Cross-origin image is observable, with renderTime equal to 0.:
FAIL(Chrome:PASS, Safari:FAIL)
- Cross-origin image is observable, with renderTime equal to 0.:
- /largest-contentful-paint/expanded-image.html [wpt.fyi]
- Largest Contentful Paint: |size| attribute is bounded by intrinsic size.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: |size| attribute is bounded by intrinsic size.:
- /largest-contentful-paint/first-letter-background.html [wpt.fyi]
- Largest Contentful Paint: first-letter is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: first-letter is observable.:
- /largest-contentful-paint/image-TAO.sub.html [wpt.fyi]:
OK[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows10-32-2004-qr-debug,Gecko-windows10-32-2004-qr-opt,Gecko-windows10-64-2004-qr-debug,Gecko-windows10-64-2004-qr-opt,GitHub],TIMEOUT[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome:OK, Safari:OK)- Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.:
FAIL(Chrome:PASS, Safari:FAIL)
- Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.:
- /largest-contentful-paint/image-full-viewport.html [wpt.fyi]
- The intersectionRect of an img element overflowing is computed correctly:
FAIL(Chrome:PASS, Safari:FAIL)
- The intersectionRect of an img element overflowing is computed correctly:
- /largest-contentful-paint/image-inside-svg.html [wpt.fyi]
- Image inside SVG is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Image inside SVG is observable.:
- /largest-contentful-paint/image-not-fully-visible.html [wpt.fyi]
- The intersectionRect of an img element overflowing is computed correctly:
FAIL(Chrome:PASS, Safari:FAIL)
- The intersectionRect of an img element overflowing is computed correctly:
- /largest-contentful-paint/image-removed-before-load.html [wpt.fyi]
- Largest Contentful Paint: image removed before loaded does not produce entry.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: image removed before loaded does not produce entry.:
- /largest-contentful-paint/image-src-change.html [wpt.fyi]:
OK[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows10-32-2004-qr-debug,Gecko-windows10-32-2004-qr-opt,Gecko-windows10-64-2004-qr-debug,Gecko-windows10-64-2004-qr-opt,GitHub],TIMEOUT[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome:OK, Safari:OK)- Largest Contentful Paint: changing src causes a new entry to be dispatched.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: changing src causes a new entry to be dispatched.:
- /largest-contentful-paint/image-sw-same-origin.https.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR) - /largest-contentful-paint/image-upscaling.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR) - /largest-contentful-paint/larger-image.html [wpt.fyi]
- Largest Contentful Paint: largest image is reported.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: largest image is reported.:
- /largest-contentful-paint/loadTime-after-appendChild.html [wpt.fyi]
- Image loadTime occurs after appendChild is called.:
FAIL(Chrome:PASS, Safari:FAIL)
- Image loadTime occurs after appendChild is called.:
- /largest-contentful-paint/multiple-redirects-TAO.html [wpt.fyi]
- Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.:
FAIL(Chrome:PASS, Safari:FAIL)
- Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.:
- /largest-contentful-paint/observe-after-untrusted-scroll.html [wpt.fyi]
- Same-origin image after a JS initiated scroll event is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Same-origin image after a JS initiated scroll event is observable.:
- /largest-contentful-paint/observe-image.html [wpt.fyi]
- Same-origin image is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Same-origin image is observable.:
- /largest-contentful-paint/observe-svg-background-image.html [wpt.fyi]
- Same-origin SVG background image is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Same-origin SVG background image is observable.:
- /largest-contentful-paint/observe-svg-data-uri-background-image.html [wpt.fyi]:
OK[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows10-32-2004-qr-debug,Gecko-windows10-32-2004-qr-opt,Gecko-windows10-64-2004-qr-debug,Gecko-windows10-64-2004-qr-opt,GitHub],TIMEOUT[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome:OK, Safari:OK)- Data-URI background SVG image is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Data-URI background SVG image is observable.:
- /largest-contentful-paint/observe-svg-data-uri-image.html [wpt.fyi]
- Same-origin image is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Same-origin image is observable.:
- /largest-contentful-paint/observe-svg-image.html [wpt.fyi]
- Same-origin image is observable.:
FAIL(Chrome:PASS, Safari:FAIL)
- Same-origin image is observable.:
- /largest-contentful-paint/placeholder-image.html [wpt.fyi]
- Largest Contentful Paint: changing src causes a new entry to be dispatched.:
FAIL(Chrome:PASS, Safari:FAIL)
- Largest Contentful Paint: changing src causes a new entry to be dispatched.:
- /largest-contentful-paint/redirects-tao-star.html [wpt.fyi]
- Cross-origin image without TAO should not have its renderTime set, with full TAO it should.:
FAIL(Chrome:PASS, Safari:FAIL)
- Cross-origin image without TAO should not have its renderTime set, with full TAO it should.:
- /largest-contentful-paint/repeated-image.html [wpt.fyi]
- Repeated image produces different timestamps.:
FAIL(Chrome:PASS, Safari:FAIL)
- Repeated image produces different timestamps.:
- /largest-contentful-paint/same-origin-redirects.html [wpt.fyi]:
OK[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows10-32-2004-qr-debug,Gecko-windows10-32-2004-qr-opt,Gecko-windows10-64-2004-qr-debug,Gecko-windows10-64-2004-qr-opt,GitHub],TIMEOUT[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome:OK, Safari:OK)- Same-origin image redirect without TAO should have its renderTime set.:
FAIL(Chrome:PASS, Safari:FAIL)
- Same-origin image redirect without TAO should have its renderTime set.:
- /largest-contentful-paint/video-poster.html [wpt.fyi]:
CRASH[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview],OK[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows10-32-2004-qr-debug,Gecko-windows10-32-2004-qr-opt,Gecko-windows10-64-2004-qr-debug,Gecko-windows10-64-2004-qr-opt,GitHub] (Chrome:OK, Safari:OK)- Able to observe a video's poster image.:
FAIL(Chrome:PASS, Safari:FAIL)
- Able to observe a video's poster image.:
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/989145c10e12
[wpt PR 35643] - Report the time of a video's first displayed frame for LCP, a=testonly
https://hg.mozilla.org/integration/autoland/rev/e19869e38e38
[wpt PR 35643] - Update wpt metadata, a=testonly
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/989145c10e12
https://hg.mozilla.org/mozilla-central/rev/e19869e38e38
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•