1794945 - [wpt-sync] Sync PR 36424 - Revert "Report the time of a video's first displayed frame for LCP"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36424 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36424
Details from upstream follow.

Dana Fried <[e-mail]> wrote:

Revert "Report the time of a video's first displayed frame for LCP"

This reverts commit ba1da51a29d331b40e90cbed08c2a379e96dacc1.

Reason for revert: Test is failing on a number of builders.
Bug: 1373981
Owners-Override: Dana Fried \<[e-mail]>

Original change's description:

Report the time of a video's first displayed frame for LCP

This CL plumbs the information needed to capture LCP from videos
into Video timing information for LCP into the HTMLVideoElement, from
where it is sent to the PaintTimingDetector when the initial frame is
displayed.

Video byte size is taken from the WebMediaPlayer's PipelineStatistics,
while the result of the Timing-Allow-Origin check goes through URLIndex,
in the same manner as CORS checks.

Bug: 1289664
Change-Id: I9e8ed63a2913d5dc70b0f1b2bf9f928db4f1b908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3814106
Commit-Queue: Ian Clelland \<[e-mail]>
Reviewed-by: Yoav Weiss \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1058088}

Bug: 1289664
Change-Id: I1be173c71d5e39c333ca61a9c8c9b73f28b598af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3949734
Commit-Queue: Dana Fried \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Dana Fried \<[e-mail]>
Reviewed-by: Ian Clelland \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1058179}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36424 applied with additional changes from upstream: e7d2b67bdff36e4fa5dac08ef106b2235b167294

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fca401050b2c75b71cfaf810405ef0e0117f2dd1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 32 tests and 1 subtests

Status Summary

Firefox

OK : 30
FAIL : 30
ERROR: 2

Chrome

OK : 32
PASS : 31
FAIL : 10

Safari

OK : 30
FAIL : 30
ERROR: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /largest-contentful-paint/animated/observe-animated-image-gif.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /largest-contentful-paint/animated/observe-animated-image-webp.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /largest-contentful-paint/animated/observe-animated-image.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /largest-contentful-paint/animated/observe-cross-origin-animated-image.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /largest-contentful-paint/animated/observe-cross-origin-tao-animated-image.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /largest-contentful-paint/animated/observe-non-animated-image.tentative.html [wpt.fyi]
  • Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
• /largest-contentful-paint/contracted-image.html [wpt.fyi]
  • Largest Contentful Paint: |size| attribute is bounded by display size.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/cross-origin-image.sub.html [wpt.fyi]
  • Cross-origin image is observable, with renderTime equal to 0.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/expanded-image.html [wpt.fyi]
  • Largest Contentful Paint: |size| attribute is bounded by intrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/first-letter-background.html [wpt.fyi]
  • Largest Contentful Paint: first-letter is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-TAO.sub.html [wpt.fyi]
  • Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-full-viewport.html [wpt.fyi]
  • The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-inside-svg.html [wpt.fyi]
  • Image inside SVG is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-not-fully-visible.html [wpt.fyi]
  • The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-removed-before-load.html [wpt.fyi]
  • Largest Contentful Paint: image removed before loaded does not produce entry.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-src-change.html [wpt.fyi]
  • Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/image-sw-same-origin.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /largest-contentful-paint/image-upscaling.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /largest-contentful-paint/larger-image.html [wpt.fyi]
  • Largest Contentful Paint: largest image is reported.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/loadTime-after-appendChild.html [wpt.fyi]
  • Image loadTime occurs after appendChild is called.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/multiple-redirects-TAO.html [wpt.fyi]
  • Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/observe-after-untrusted-scroll.html [wpt.fyi]
  • Same-origin image after a JS initiated scroll event is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/observe-image.html [wpt.fyi]
  • Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/observe-svg-background-image.html [wpt.fyi]
  • Same-origin SVG background image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/observe-svg-data-uri-background-image.html [wpt.fyi]
  • Data-URI background SVG image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/observe-svg-data-uri-image.html [wpt.fyi]
  • Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/observe-svg-image.html [wpt.fyi]
  • Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/placeholder-image.html [wpt.fyi]
  • Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/redirects-tao-star.html [wpt.fyi]
  • Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/repeated-image.html [wpt.fyi]
  • Repeated image produces different timestamps.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/same-origin-redirects.html [wpt.fyi]
  • Same-origin image redirect without TAO should have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
• /largest-contentful-paint/video-poster.html [wpt.fyi]
  • Able to observe a video's poster image.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1293551320f2
[wpt PR 36424] - Revert "Report the time of a video's first displayed frame for LCP", a=testonly
https://hg.mozilla.org/integration/autoland/rev/b39605158488
[wpt PR 36424] - Update wpt metadata, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1293551320f2
https://hg.mozilla.org/mozilla-central/rev/b39605158488