Closed Bug 1794983 Opened 3 years ago Closed 3 years ago

[Wayland] Throttle frame fallback when window is minimized

Categories

(Core :: Widget: Gtk, enhancement, P3)

Product:
Core
Component:
Widget: Gtk
Type:
enhancement

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: stransky, Assigned: stransky)

References

(
URL
)

Details

There's no point to go full speed the when window is minimized.

FWIW, I'm really surprised about this. This may well be a compositor bug - I'll check in Mutter. Still probably a good idea to do something about it in FF, but we need to keep in mind that there can be window previews.

Just confirmed with weston-simple-egl that Mutter does not correctly throttle frame callbacks when minimized - I'll look into it. So maybe no point for you bothering here.

Yes, KDE throttles frame callbacks for minimized windows.

Tested on Gnome and even if I hit 'minimize' icon and a window is minimized, we don't get 'minimized' window state event - it looks like this state is ignored on gnome-shell/mutter. So the patch I did for is doesn't work as we don't get minimized state info.

Yeah, I'm afraid that's how the protocol works :/ https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/stable/xdg-shell/xdg-shell.xml#L1047-1054:

Request that the compositor minimize your surface. There is no way to know if the surface is currently minimized, nor is there any way to unset minimization on this surface.

But the following part is better:

If you are looking to throttle redrawing when minimized, please instead use the wl_surface.frame event for this, as this will also work with live previews on windows in Alt-Tab, Expose or similar compositor features.

Hehe, somebody knew! :)

Anyhow, will try to investigate the Mutter issue this WE.

Fixed in Gnome/Mutter 43.1/42.6, due on 22. Okt.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.