Closed Bug 1795006 Opened 2 years ago Closed 2 years ago

Make browsertime await properly for profiler stop

Categories

(Testing :: Raptor, task, P1)

Product:
Testing
Component:
Raptor
Version:
Default
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: canova, Assigned: canova)

References

(Blocks 1 open bug)

Details

Browsertime uses Services.profiler.StopProfiler function to stop the profiler. Previously this function wasn't async and there was no way of knowing that this could stop all the processes or not. With Bug 1668867, we converted all of those functions to async functions that resolve when they are completely done. We should properly await for the profiler to stop in the browsertime as well.

We've seen some intermittent failures that hang at the stop function for some reason and hoping that this could solve the issue.

Severity: -- → S3
Priority: -- → P1

Spent some time looking at this and closing as we are actually awaiting for the profiler stop here: https://github.com/sitespeedio/browsertime/blob/bab2e633508f9dd34ab394513aea9e83a69eea12/lib/firefox/geckoProfiler.js#L161-L163
Instead I think the main cause was because of the hang on the gzipping phase. I sent a PR and it's merged to browsertime: https://github.com/sitespeedio/browsertime/pull/1896 Closing this.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
See Also: → https://github.com/sitespeedio/browsertime/pull/1896
You need to log in before you can comment on or make changes to this bug.