179508 - Static build on OS/2 broken

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[jhp (no longer active)]

Cannot currently generate the static build on OS/2.

Comment 1

[jhp (no longer active)]

Attachment: patch

Comment 2

[jhp (no longer active)]

Kaply, check it out, see if there are any problems.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 105839 [details] [diff] [review]
patch

>-static const void *
>+static const void * PR_CALLBACK

Use PR_STATIC_CALLBACK(void *) here.

Same with the rest of this file.

Otherwise, r=mkaply

Still need cls r=

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 105839 [details] [diff] [review]
patch

r=cls

Comment 5

[jhp (no longer active)]

Attachment: patch w/ Kaply's comments

Comment 6

[hacker formerly known as [e-mail]]

Comment on attachment 105885 [details] [diff] [review]
patch w/ Kaply's comments

Alec, can you sr the xpcom code that gets modified?

Comment 7

[Alec Flett]

Comment on attachment 105885 [details] [diff] [review]
patch w/ Kaply's comments

sr=alecf

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Create shared code between gfx and widget

Rather than do the renaming in Javier's patch, I have a different approach.

I'm going to put our generic Unicode classes into gkgfx since that is linked
against widget and gfx.

I've verified that the code is shared.

We destruct the array in the DTOR for gfx.

Need r= from cls and pedemonte

Comment 9

[jhp (no longer active)]

Comment on attachment 106243 [details] [diff] [review]
Create shared code between gfx and widget

review pending:

+  static FreeUconvObjects();
This function should have a 'void' return type.  I know VACPP doesn't complain,
bug gcc does.

Also, in the two new files you created, should they be triple licensed?  And
why is John Fairhurst still listed in the copyright?  I thought the functions
in these files had been completely rewritten and didn't include any of his old
code.

Comment 10

[Mike Kaply [:mkaply]]

Attachment: Patch with Javier's comments

Fixed licenses and return.

Need r=from pedemont on code and r=from cls on gfx/src Makefile changes.

Comment 11

[hacker formerly known as [e-mail]]

r=cls on the Makefile change

Comment 12

[jhp (no longer active)]

Comment on attachment 106668 [details] [diff] [review]
Patch with Javier's comments

r=pedemont

Comment 13

[Mike Kaply [:mkaply]]

Fix checked in