Static build on OS/2 broken

RESOLVED FIXED in mozilla1.3alpha

Status

SeaMonkey
Build Config
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: jhp (no longer active), Assigned: hacker formerly known as seawood@netscape.com)

Tracking

Trunk
mozilla1.3alpha
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

15 years ago
Cannot currently generate the static build on OS/2.
(Reporter)

Comment 1

15 years ago
Created attachment 105839 [details] [diff] [review]
patch
(Reporter)

Comment 2

15 years ago
Kaply, check it out, see if there are any problems.
(Reporter)

Updated

15 years ago
Attachment #105839 - Flags: review?(mkaply)

Comment 3

15 years ago
Comment on attachment 105839 [details] [diff] [review]
patch

>-static const void *
>+static const void * PR_CALLBACK

Use PR_STATIC_CALLBACK(void *) here.

Same with the rest of this file.

Otherwise, r=mkaply

Still need cls r=
Attachment #105839 - Flags: review?(mkaply) → review+
(Reporter)

Comment 5

15 years ago
Created attachment 105885 [details] [diff] [review]
patch w/ Kaply's comments
(Reporter)

Updated

15 years ago
Attachment #105839 - Attachment is obsolete: true
Attachment #105885 - Flags: review+
Comment on attachment 105885 [details] [diff] [review]
patch w/ Kaply's comments

Alec, can you sr the xpcom code that gets modified?
Attachment #105885 - Flags: superreview?(alecf)

Comment 7

15 years ago
Comment on attachment 105885 [details] [diff] [review]
patch w/ Kaply's comments

sr=alecf
Attachment #105885 - Flags: superreview?(alecf) → superreview+

Comment 8

15 years ago
Created attachment 106243 [details] [diff] [review]
Create shared code between gfx and widget

Rather than do the renaming in Javier's patch, I have a different approach.

I'm going to put our generic Unicode classes into gkgfx since that is linked
against widget and gfx.

I've verified that the code is shared.

We destruct the array in the DTOR for gfx.

Need r= from cls and pedemonte
(Reporter)

Comment 9

15 years ago
Comment on attachment 106243 [details] [diff] [review]
Create shared code between gfx and widget

review pending:

+  static FreeUconvObjects();
This function should have a 'void' return type.  I know VACPP doesn't complain,
bug gcc does.

Also, in the two new files you created, should they be triple licensed?  And
why is John Fairhurst still listed in the copyright?  I thought the functions
in these files had been completely rewritten and didn't include any of his old
code.

Comment 10

15 years ago
Created attachment 106668 [details] [diff] [review]
Patch with Javier's comments

Fixed licenses and return.

Need r=from pedemont on code and r=from cls on gfx/src Makefile changes.
Attachment #106243 - Attachment is obsolete: true

Updated

15 years ago
Attachment #106668 - Flags: review?(pedemont)
r=cls on the Makefile change
(Reporter)

Comment 12

15 years ago
Comment on attachment 106668 [details] [diff] [review]
Patch with Javier's comments

r=pedemont
Attachment #106668 - Flags: review?(pedemont) → review+

Comment 13

15 years ago
Fix checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.3alpha
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.