1795139 - (CVE-2022-46877) Consider showing fullscreen notification as soon as browser window goes into fullscreen mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Edgar Chen [:edgar]]

Currently the fullscreen notification is shown only when both browser window and web content goes into fullscreen mode which require several IPC message to exchanges the status.
But I think the notification is more about to notify the user that the browser window is going to switch to fullscreen mode (because the toolbar and urlbar will be hidden). We could consider showing the notification as soon as browser window goes into fullscreen mode, I would expect this could make notification shown faster.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1795139 - Show fullscreen notification as soon as browser window goes into fullscreen mode; r?smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bcb400dc170
Show fullscreen notification as soon as browser window goes into fullscreen mode; r=smaug

Comment 3

[Iulian Moraru]

Backed out for causing mochitest failures on test_MozDomFullscreen_event.xhtml.

Push with failures

Failure log

Backout link

[task 2022-10-18T12:58:58.105Z] 12:58:58     INFO - TEST-START | dom/tests/mochitest/chrome/test_MozDomFullscreen_event.xhtml
[task 2022-10-18T12:58:58.109Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:180
[task 2022-10-18T12:58:58.110Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/security/nsCSPService.cpp:190
[task 2022-10-18T12:58:58.125Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: early callback, or time went backwards: '!aAllowIdleDispatch', file /builds/worker/checkouts/gecko/xpcom/threads/IdleTaskRunner.cpp:198
[task 2022-10-18T12:58:58.325Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: NS_ENSURE_TRUE(uri) failed: file /builds/worker/checkouts/gecko/caps/BasePrincipal.cpp:1383
[task 2022-10-18T12:58:58.437Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1234
[task 2022-10-18T12:58:58.539Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1234
[task 2022-10-18T12:58:58.588Z] 12:58:58     INFO - GECKO(1998) | must wait for focus
[task 2022-10-18T12:58:58.625Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:500
[task 2022-10-18T12:58:58.628Z] 12:58:58     INFO - GECKO(1998) | [GLX] window 2200061 has VisualID 0x41
[task 2022-10-18T12:58:58.639Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Renderer] WARNING: robust_buffer_access_behavior marked as unsupported: file /builds/worker/checkouts/gecko/gfx/gl/GLContextFeatures.cpp:632
[task 2022-10-18T12:58:58.639Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Renderer] WARNING: Robustness supported, strategy is not LOSE_CONTEXT_ON_RESET!: file /builds/worker/checkouts/gecko/gfx/gl/GLContext.cpp:995
[task 2022-10-18T12:58:58.640Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Renderer] WARNING: robustness marked as unsupported: file /builds/worker/checkouts/gecko/gfx/gl/GLContextFeatures.cpp:632
[task 2022-10-18T12:58:58.642Z] 12:58:58     INFO - GECKO(1998) | [2022-10-18T12:58:58Z WARN  webrender::device::gl] Missing optimized shader source for gpu_cache_update
[task 2022-10-18T12:58:58.646Z] 12:58:58     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: '!scrollbar', file /builds/worker/checkouts/gecko/widget/Theme.cpp:1070
[task 2022-10-18T12:58:59.562Z] 12:58:59     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: '!scrollbar', file /builds/worker/checkouts/gecko/widget/Theme.cpp:1070
[task 2022-10-18T12:58:59.687Z] 12:58:59     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: '!scrollbar', file /builds/worker/checkouts/gecko/widget/Theme.cpp:1070
[task 2022-10-18T12:58:59.703Z] 12:58:59     INFO - GECKO(1998) | [2022-10-18T12:58:59Z WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2022-10-18T12:58:59.704Z] 12:58:59     INFO - GECKO(1998) | [2022-10-18T12:58:59Z WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2022-10-18T12:58:59.706Z] 12:58:59     INFO - GECKO(1998) | [2022-10-18T12:58:59Z WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None
[task 2022-10-18T13:04:26.146Z] 13:04:26     INFO - TEST-INFO | started process screentopng
[task 2022-10-18T13:04:26.264Z] 13:04:26     INFO - TEST-INFO | screentopng: exit 0
[task 2022-10-18T13:04:26.264Z] 13:04:26     INFO - Buffered messages logged at 12:58:59
[task 2022-10-18T13:04:26.265Z] 13:04:26     INFO - TEST-PASS | dom/tests/mochitest/chrome/test_MozDomFullscreen_event.xhtml | MozDOMFullscreen:Entered shouldn't have been triggered twice 
[task 2022-10-18T13:04:26.265Z] 13:04:26     INFO - TEST-PASS | dom/tests/mochitest/chrome/test_MozDomFullscreen_event.xhtml | First MozDOMFullscreen:Entered should be targeted at outer body 
[task 2022-10-18T13:04:26.265Z] 13:04:26     INFO - Buffered messages finished
[task 2022-10-18T13:04:26.265Z] 13:04:26     INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/chrome/test_MozDomFullscreen_event.xhtml | Test timed out. - 
[task 2022-10-18T13:04:27.149Z] 13:04:27     INFO - GECKO(1998) | MEMORY STAT | vsize 3309MB | residentFast 528MB | heapAllocated 232MB
[task 2022-10-18T13:04:27.156Z] 13:04:27     INFO - TEST-OK | dom/tests/mochitest/chrome/test_MozDomFullscreen_event.xhtml | took 329051ms
[task 2022-10-18T13:04:27.274Z] 13:04:27     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:500
[task 2022-10-18T13:04:27.276Z] 13:04:27     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: '!scrollbar', file /builds/worker/checkouts/gecko/widget/Theme.cpp:1070
[task 2022-10-18T13:04:28.165Z] 13:04:28     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:180
[task 2022-10-18T13:04:28.166Z] 13:04:28     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/security/nsCSPService.cpp:190
[task 2022-10-18T13:04:28.186Z] 13:04:28     INFO - GECKO(1998) | [Parent 1998, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1234
[task 2022-10-18T13:04:28.249Z] 13:04:28     INFO - TEST-START | dom/tests/mochitest/chrome/test_activation.xhtml

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=6e71e16238a5981d96a4919a905dc85d1d426398

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/563c8c5f4b3e
Show fullscreen notification as soon as browser window goes into fullscreen mode; r=smaug

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/563c8c5f4b3e

Comment 8

[Tom Ritter [:tjr]]

Attachment: advisory.txt

Comment 9

[Edgar Chen [:edgar]]

Comment on attachment 9298625 [details]
Bug 1795139 - Show fullscreen notification as soon as browser window goes into fullscreen mode; r?smaug

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Though this is a sec-low, but it also help other sec bug in some way, like bug 1794622.
• User impact if declined: Fullscreen notification might be delay to show if page makes browser busy .
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only changes the timing we show the fullscreen notification, and we haven't received any regression.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9298625 [details]
Bug 1795139 - Show fullscreen notification as soon as browser window goes into fullscreen mode; r?smaug

Approved for 102.7esr.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/7968f9296e4c