1795179 - `HTMLEditor` shouldn't split atomic nodes when `Selection` is collapsed in it

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is the root cause of bug 1793873, but this requires a risky patch. Therefore, this should be fixed in the next cycle.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1795179 - Make some elements non-splittable r=m_kato!

One of the reason of bug 1793873 is, HTMLEditUtils::IsSplittableNode returns
false for <textarea>. Then, insertParagraph etc command with Selection
collapsed in <textarea> causes splitting the <textarea> and it's not split
at same parent.

Then, I found that we need to take care <button> specially. It creates a
block formatting context, and it's a form control so that it should never be
split. Therefore, HTMLEditor::GetAncestorElement requires to take care of
<button> element with additional scan option for minimizing the risk.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/038341029e6b
Make some elements non-splittable r=m_kato

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36542 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/038341029e6b

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot