1795213 - Fluent error message in terminal when install popup is displayed

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce:

1. Go to an addon page (e.g. https://addons.mozilla.org/en-US/firefox/addon/phab-conventional-comments/)
2. Click on the "Add to Firefox" button

Actual result:

I can see the following error messages in the terminal

[fluent] Missing message in locale en-US: 
[fluent] Couldn't find a message: 
[dom/l10n] Errors during l10n mutation frame.

These are really not helpful as it looks like we're trying to retrieve a message with an empty string, but we don't know from where

Comment 1

[Rob Wu [:robwu]]

I don't see the warning at first, but I can reproduce this (e.g. in 106 and 107) by triggering the prompt again: switch to a different tab and then back, or dismiss the doorhanger (cancel install) and repeat step 2 of the above STR.

I also tested with another doorhanger in a similar place (permission request for Notification API), and the issue doesn't occur there.

The install doorhanger uses .properties bundles. It's not obvious how this l10n warning is caused/related to the install doorhanger itself, or how to debug this.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:zombie, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[William Durand [:willdurand]]

Hi :eemeli, do you know what could be the problem here? Thanks.

Comment 4

[Eemeli Aro [:eemeli]]

My guess would be some code setting a data-l10n-id to an empty string, but I can't replicate the problem locally on 108, 109, or nightly so figuring out more is difficult.

Do the replication steps still produce this error for you in a more recent build than the 107 mentioned above?

Comment 5

[William Durand [:willdurand]]

Yes, I can reproduce using the STR in Comment 0 on a Nightly debug build (macOS). I see the messages in the browser console (coming from browser.xhtml apparently).

Comment 6

[William Durand [:willdurand]]

Ha. I think I see what's going on.. In Bug 1785216, some code has been added to "unset" the data-l10n-id by setting it to an empty string. My understanding of Comment 4 is that we shouldn't be doing this.

Comment 7

[William Durand [:willdurand]]

Attachment: Bug 1795213 - Remove `data-l10n-id` attribute instead of setting it to an empty value. r?eemeli!

Comment 8

[Eemeli Aro [:eemeli]]

D'oh! Thank you for fixing this bug that I'd introduced.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f471cdfbd23
Remove `data-l10n-id` attribute instead of setting it to an empty value. r=eemeli

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1f471cdfbd23