1795322 - Update non-code & other references for migrated ES modules files

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1792341, there's a few cases noticed where there's comments or document references to the previous jsm files that we should update to the new ES module references.

We'll let that bug land, and then use searchfox to do fresh queries for all the toolkit/modules files changed.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit module references in devtools. r?#devtools-reviewers

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in marionette related code. r?whimboo

Depends on D160025

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in services code. r?markh

Depends on D160026

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in update code. r?#application-update-reviewers

Depends on D160027

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in telemetry code. r?dexter

Depends on D160028

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in enterprise policy code. r?mkaply

Depends on D160029

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in browser/ code. r?Mossop,Gijs

Depends on D160030

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in places and storage code. r?mak

Depends on D160031

Comment 9

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in toolkit code. r?Mossop,Gijs

Depends on D160032

Comment 10

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in dom code. r?mccr8

Depends on D160033

Comment 11

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in testing code r?gbrown

Depends on D160034

Comment 12

[Mark Banner (:standard8)]

Attachment: Bug 1795322 - Update toolkit modules references in remaining places. r?Mossop,Gijs

Depends on D160035

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89aea8373411
Update toolkit module references in devtools. r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/38df43b4a70f
Update toolkit modules references in marionette related code. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/f2c118b6c6ce
Update toolkit modules references in services code. r=bdk
https://hg.mozilla.org/integration/autoland/rev/c8a7a40c2a2f
Update toolkit modules references in update code. r=application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/9fb873ecfb31
Update toolkit modules references in telemetry code. r=Dexter
https://hg.mozilla.org/integration/autoland/rev/6ac8a611f8c7
Update toolkit modules references in enterprise policy code. r=mkaply
https://hg.mozilla.org/integration/autoland/rev/bc6a674994ad
Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/60cc71c61cad
Update toolkit modules references in places and storage code. r=mak
https://hg.mozilla.org/integration/autoland/rev/db8903454bd3
Update toolkit modules references in toolkit code. r=mossop
https://hg.mozilla.org/integration/autoland/rev/8e8d790eb0f4
Update toolkit modules references in dom code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/a4a35005ada9
Update toolkit modules references in testing code r=gbrown,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/aba25cbcda51
Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu

Comment 14

[Natalia Csoregi [:nataliaCs]]

Backed out for causing multiple failures e.g. test_deletion_request_ping.py

• backout: https://hg.mozilla.org/integration/autoland/rev/f3e4c01e0b6bd75cb26f649b3b11a008864ebc0e
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=X6YnbcRmRLWaW_9RHNnKuw.0&revision=aba25cbcda5154e172d4bff3cee18a621b6841c3
• failure logs:
  • TEST-UNEXPECTED-ERROR | telemetry/marionette/tests/client/test_deletion_request_ping.py TestDeletionRequestPing.test_deletion_request_ping_across_sessions | marionette_driver.errors.JavascriptException: TypeError: ChromeUtils.importESModules is not a function
  • TEST-UNEXPECTED-ERROR | testing/firefox-ui/tests/functional/safebrowsing/test_initial_download.py TestSafeBrowsingInitialDownload.test_safe_browsing_initial_download | marionette_driver.errors.JavascriptException: TypeError: ChromeUtils.importESModules is not a function
  • TEST-UNEXPECTED-ERROR | testing/marionette/harness/marionette_harness/tests/unit/test_cli_arguments.py TestCommandLineArguments.test_debugger_address_cdp_status | marionette_driver.errors.JavascriptException: TypeError: ChromeUtils.importESModules is not a function

Comment 15

[Mark Banner (:standard8)]

Sigh, ./mach try auto obviously didn't catch that :(

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73ecf1feeae7
Update toolkit module references in devtools. r=devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/9efe4852682a
Update toolkit modules references in marionette related code. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/0b02fecc2b86
Update toolkit modules references in services code. r=bdk
https://hg.mozilla.org/integration/autoland/rev/3d69190810ec
Update toolkit modules references in update code. r=application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/d53bb4a80587
Update toolkit modules references in telemetry code. r=Dexter
https://hg.mozilla.org/integration/autoland/rev/15980c1375f9
Update toolkit modules references in enterprise policy code. r=mkaply
https://hg.mozilla.org/integration/autoland/rev/a44bb1a8ce30
Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/1289ee57fcfe
Update toolkit modules references in places and storage code. r=mak
https://hg.mozilla.org/integration/autoland/rev/45853c4b7277
Update toolkit modules references in toolkit code. r=mossop
https://hg.mozilla.org/integration/autoland/rev/a5d7a2662d19
Update toolkit modules references in dom code. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/086d24cf6c12
Update toolkit modules references in testing code r=gbrown,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/37ffd0d5edcf
Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/73ecf1feeae7
https://hg.mozilla.org/mozilla-central/rev/9efe4852682a
https://hg.mozilla.org/mozilla-central/rev/0b02fecc2b86
https://hg.mozilla.org/mozilla-central/rev/3d69190810ec
https://hg.mozilla.org/mozilla-central/rev/d53bb4a80587
https://hg.mozilla.org/mozilla-central/rev/15980c1375f9
https://hg.mozilla.org/mozilla-central/rev/a44bb1a8ce30
https://hg.mozilla.org/mozilla-central/rev/1289ee57fcfe
https://hg.mozilla.org/mozilla-central/rev/45853c4b7277
https://hg.mozilla.org/mozilla-central/rev/a5d7a2662d19
https://hg.mozilla.org/mozilla-central/rev/086d24cf6c12
https://hg.mozilla.org/mozilla-central/rev/37ffd0d5edcf