Closed Bug 1795350 Opened 2 years ago Closed 2 months ago

Support more customizations of ReaderView appearance controls

Categories

(Fenix :: WebExtensions, enhancement)

All
Android
enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: csadilek, Unassigned)

References

(Depends on 1 open bug)

Details

From github: https://github.com/mozilla-mobile/android-components/issues/3400.

The current solution is good enough for Android OS themes but not straight-forward to use with application styles (e.g. the Fenix private mode), because of problems with using dynamic color references (?android:textColorPrimary).

In Fenix, we worked around the problem by programmatically setting the ColorStateList based on the application style.

One issue that prompted this workaround was when setting the style-dependent color attribute <color name="mozac_feature_readerview_text_color">?android:textColorPrimary</color> it was only being applied to half of the screen (see below). This shall also be known as the . :grinning:

See also:
https://github.com/mozilla-mobile/fenix/issues/3289
https://github.com/mozilla-mobile/fenix/issues/3252

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(cpeterson)
Severity: -- → N/A
Type: defect → enhancement
Flags: needinfo?(cpeterson)

I considered fixing this, but the work to figure out how to get themed ColorStateLists to work doesn't seem worth it when we are planning to replace this with the built-in readerview in bug 1770985.

Status: NEW → RESOLVED
Closed: 2 months ago
Depends on: 1770985
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.