Closed Bug 1795370 Opened 2 years ago Closed 2 years ago

Add nsICrashReporter to component definition as an interface on nsAppRunner, and transition code to use Services.appinfo

Categories

(Toolkit :: Crash Reporting, task)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1402519 made it so that the nsICrashReporter interface on nsAppRunner was permanent and not dependent on a build switch.

I think we can therefore declare it as a valid interface in the components.conf file.

This will also fix some ESLint issues with a new (manually-run) ESLint rule for mozilla/valid-services-property where Services.appinfo.annotateCrashReport is currently being reported as an unknown property.

The other side-effect of adding that interface is that ESLint picks up instances of:

Cc["@mozilla.org/toolkit/crash-reporter;1"].getService(Ci.nsICrashReporter);

which can now be replaced by Services.appinfo.

I currently have a patch running through try server which should fix all the issues here.

This fixes ESLint issues raised by mozilla/valid-services-properties.
This also changes follow-on issues to use Services.appinfo rather than getService.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8deff28b003
Add nsICrashReporter as an interface on nsAppRunner. r=gsvelto
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: