1795460 - font visibility = 1: auto include preferred language from kLangPackFonts

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Thorin [:thorin]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

Similar to Bug 1670199, but this is to improve usability

kBaseFonts is rather discriminatory to users of kLangPackFonts, so for example a user requesting pages in Korean is going to get broken unicode (IIUIC)

I propose that if navigator.language (and the first language in accept headers) meets a certain list, we include the relevant kLangPackFonts

So for example, if the first language requested is ko-* or ko, on windows, we also allow GulimChe (monospace) and Batang (serif). Note: Malgun Gothic is already part of kBaseFonts

This shouldn't affect entropy, as the user would be expected to have those fonts (why else would they be requesting korean web content?) and they are already requesting Korean

I do not know how feasible this would be, and while I wouldn't expect users to change preferred language mid-session, it would reflect globally in already open tabs/windows, not per eTLD+1 + scheme

Comment 1

[Thorin [:thorin]]

tom, didn't you open a similar issue for FPP - if so , close this.

Comment 2

[Tom Ritter [:tjr]]

I don't think there's a different bug... FPP includes language packs entirely so this specific idea wouldn't be it. We had theorized that maybe we could restrict the language pack list in this way but I don't think I put it in a bug so much as a speculative idea if we find that it would be the best thing to do to reduce entropy in practice. (Using the forthcoming measurement data vs just guessing.)

Comment 3

[Thorin [:thorin]]

We had theorized that maybe we could restrict the language pack list in this way

that's what I meant .. that FPP would be tightened but not (hopefully) break "localized" content

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1795460 - Allow certain fonts based on locale. r?timhuang

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e17f1517c34f
https://hg.mozilla.org/integration/autoland/rev/6546fee8a01d
Allow certain fonts based on locale. r=timhuang

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9bc05be7b90e
https://hg.mozilla.org/integration/autoland/rev/c9d1677e6331
Revert "Bug 1795460 - Allow certain fonts based on locale. r=timhuang" for causing build bustages @ nsRFPService.cpp

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ nsRFPService.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/c9d1677e633199a0f086110b5cb5d81146696abb

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/toolkit/components/resistfingerprinting/nsRFPService.cpp:2806:8: error: no member named 'call_once' in namespace 'std'; did you mean 'calloc'?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/88c25c257717
https://hg.mozilla.org/integration/autoland/rev/cf0906c2cba4
Allow certain fonts based on locale. r=timhuang

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a7c18eafeea5
https://hg.mozilla.org/integration/autoland/rev/6d15197e9f3a
Revert "Bug 1795460 - Allow certain fonts based on locale. r=timhuang" for causing build bustages in StandardFonts-linux.inc

Comment 10

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/gfx/2d/../thebes/StandardFonts-linux.inc:1012:20: error: 'kBaseFonts_Fedora_38' defined but not used [-Werror=unused-variable]

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ebc698e3d22b
https://hg.mozilla.org/integration/autoland/rev/47680534452c
Allow certain fonts based on locale. r=timhuang

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/157d70771c8b
https://hg.mozilla.org/integration/autoland/rev/f24c23433bed
Revert "Bug 1795460 - Allow certain fonts based on locale. r=timhuang" for causing build bustages @StandardFonts-linux.inc.

Comment 13

[agoloman]

Backed out for causing build bustages @StandardFonts-linux.inc.

• Backout link
• Push with failures
• Failure Log

Comment 14

[Tom Ritter [:tjr]]

Uhg, sorry. I missed one variable with [[maybe_unused]]

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fb1cfbfd992c
https://hg.mozilla.org/integration/autoland/rev/8a47333e6aa0
Allow certain fonts based on locale. r=timhuang

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8a47333e6aa0