Closed
Bug 17955
Opened 26 years ago
Closed 26 years ago
[mlk][perf][DOGFOOD] don't add script event listeners to `overlay' nodes
Categories
(Core :: XUL, defect, P1)
Core
XUL
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: waterson, Assigned: waterson)
Details
Attachments
(1 file)
|
5.76 KB,
patch
|
Details | Diff | Splinter Review |
Adding a script event listener to a placeholder node that is used for overlay
processing is both 1) wasteful and 2) leaky. Don't do it! Attaching a patch that
modifies nsXULElement::Create(nsXULPrototypeElement*, ...) that adds a boolean
parameter that conditionalizes this. Hyatt, can you review?
thanks,
chris
FWIW, this causes -20- of the 25 nsXULElement nodes to leak! Woohoo!
|
Assignee | |
Updated•26 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: M12
|
|
Assignee | |
Comment 1•26 years ago
|
||
|
|
Assignee | |
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
|
||
Comment 2•26 years ago
|
||
Waterson, could you verify? Thanks,
-ckritzer
|
|
Assignee | |
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
| Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•