[mlk][perf][DOGFOOD] don't add script event listeners to `overlay' nodes

VERIFIED FIXED in M12

Status

()

Core
XUL
P1
critical
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: Chris Waterson, Assigned: Chris Waterson)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
Adding a script event listener to a placeholder node that is used for overlay
processing is both 1) wasteful and 2) leaky. Don't do it! Attaching a patch that
modifies nsXULElement::Create(nsXULPrototypeElement*, ...) that adds a boolean
parameter that conditionalizes this. Hyatt, can you review?

thanks,
chris

FWIW, this causes -20- of the 25 nsXULElement nodes to leak! Woohoo!
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: M12
(Assignee)

Comment 1

18 years ago
Created attachment 2599 [details] [diff] [review]
proposed fix
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 2

18 years ago
Waterson, could you verify?  Thanks,

-ckritzer
(Assignee)

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 3

18 years ago
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.