1795578 - Help text for /part says it's called leave

Status: RESOLVED FIXED

(Chat Core :: Matrix, defect)

Description

[Martin Giger [:freaktechnik]]

The help text for /part in Matrix conversation incorrectly calls the command leave. This was not detected by tests due to an issue where the test is using add_task and run_test in the same file (incorrectly, since in theory that should be possible).

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1795578 - Fix help text for part command in Matrix conversations. r=#thunderbird-reviewers

And fix all run_test + add_task tests in chat by converting them to be purely add_task.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9a580eac7280
Fix help text for part command in Matrix conversations. r=mkmelin

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: bug1795578-esr102.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Wrong command name shown in help string, so fairly little impact.
Testing completed (on c-c, etc.): Tested all the way up to beta. Also fixes the automated test that was supposed to catch exactly this issue.
Risk to taking this patch (and alternatives if risky): In terms of actual application running risk, just about none, just changes the contents of a string literal that's passed into a translation string. Some changes to xpcshell tests though.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9301364 [details] [diff] [review]
bug1795578-esr102.patch

[Triage Comment]
Approved for esr102

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/785f50d4801a