1795614 - Video memory corruption Google Pixel 7 Pro

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

From github: https://github.com/mozilla-mobile/fenix/issues/27420.

Steps to reproduce

1. This happen very in the xda-forum
2. When you look forum and open photos.
3. Then comes random pixels (This happened on Pixel 6 Pro as well, but fixed with update from Mozila. (Bugfix: Fixed image and animation corruption on Pixel 6, 6 Pro and 6a devices running Android 13) this is now with Pixel 7 Pro. )

Expected behaviour

Glitch random pixels, like gpu issue

Actual behaviour

Ransom pixels when you watching photos

Device name

Google Pixel 7 Pro

Android version

13

Firefox release type

Firefox

Firefox version

105.0

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

The Pixel 7/7Pro uses the same chipset as the 6/6 pro and so we need the same fix on that device. See bug 1787520 for details about the Pixel 6/6 Pro.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I also recently got a Pixel 7 and have been noticing the same artifacting on Reddit that was mentioned in the upstream issue.

Comment 3

[Jamie Nicol [:jnicol]]

Yes presumably this is just bug 1787520 but on the G710 as well as G78. But we need to know whether the driver version is consistent for both GPUs or whether they reset the version number.

Ryan, could you please attach your about:support

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: about:support

Comment 5

[Jamie Nicol [:jnicol]]

Attachment: Bug 1795614 - Avoid invalidating render targets on Mali-G710. r?#gfx-reviewers

In bug 1787520 we discovered a driver bug affecting Mali-G78 devices,
and added a workaround for it - avoiding invalidating no-longer-needed
render targets at the end of each render pass. It now transpires this
bug also affects Mali-G710 GPUs, so this patch applies the same
workaround for those devices too.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f29051d1592
Avoid invalidating render targets on Mali-G710. r=gfx-reviewers,jgilbert

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4f29051d1592

Comment 8

[Chris Peterson [:cpeterson]]

Jamie, should we uplift this fix to Beta 107 or ride along in a Fenix 106.0.x dot release, if there is one?

Comment 9

[Jamie Nicol [:jnicol]]

Yes we absolutely want to uplift this.

Comment 10

[Jamie Nicol [:jnicol]]

Comment on attachment 9298862 [details]
Bug 1795614 - Avoid invalidating render targets on Mali-G710. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Users with Pixel 7 phones see frequent image corruption
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Workaround for a driver bug. already fixed this on similar GPU, just making it include an additional GPU now.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Just to confirm, today's Nightly has been working reliably for me.

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9298862 [details]
Bug 1795614 - Avoid invalidating render targets on Mali-G710. r?#gfx-reviewers

Approved for 107.0b2 and Fenix/Focus 107.0b2.

Comment 13

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b5189cff408

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9298862 [details]
Bug 1795614 - Avoid invalidating render targets on Mali-G710. r?#gfx-reviewers

Although we don't have a Fenix dot release planned this week, it doesn't hurt to have the patch landed on the release branch in case we need to build one.

Comment 15

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/15b4dc412923