1795698 - Failure to import OpenPGP secret keys, if public key, with additional public subkey, is already present

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

Use GnuPG to create an advanced key.
In addition to the default [SC] and [E] keys, add another [E] key, as a result you have two [E] subkeys.

(In the test scenario, additional subkeys for [S] and [A] were added, but that probably doesn't matter.)

Export the PUBLIC key from GnuPG, store it as pubkey-1.asc

Import pubkey-1.asc into Thunderbird.

Go back to GnuPG, and use --edit-key, then delete the older [E] subkey.

(In the test scenario, in addition another used ID was added, but that probably doesn't matter.)

Export the SECRET key from GnuPG, store it as seckey-2.asc

Import seckey-2.asc as a secret key into Thunderbird.

Result: An exception is reported:

Error: rnp_key_get_protection_type failed
isSecretKeyMaterialAvailable chrome://openpgp/content/modules/RNPLib.jsm:393
protectKeyWithSubKeys chrome://openpgp/content/modules/RNPLib.jsm:468
_importKeyBlockWithAutoAccept chrome://openpgp/content/modules/RNP.jsm:2295

Comment 1

[Kai Engert [:KaiE:]]

The bug is in the Thunderbird code, which makes wrong assumptions about the combination of public keys and secret keys that are possible.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Bug 1795698 - When protecting a secret OpenPGP key, don't assume secret keys for all subkeys are available. r=mkmelin

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1795698 - Test importing secret key with existing additional public subkey. r=mkmelin

Comment 4

[Kai Engert [:KaiE:]]

The second patch adds a test.

Patch and test work on both comm-central and comm-esr102.

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 9298854 [details]
Bug 1795698 - When protecting a secret OpenPGP key, don't assume secret keys for all subkeys are available. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: Some advanced users of GnuPG cannot use their existing key with Thunderbird
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low risk

Comment 6

[Kai Engert [:KaiE:]]

This should be safe for 102.5.0, too.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d7a504dc269e
When protecting a secret OpenPGP key, don't assume secret keys for all subkeys are available. r=mkmelin
https://hg.mozilla.org/comm-central/rev/a2eb61ecd28e
Test importing secret key with existing additional public subkey. r=mkmelin

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9298854 [details]
Bug 1795698 - When protecting a secret OpenPGP key, don't assume secret keys for all subkeys are available. r=mkmelin

[Triage Comment]
Approved for beta

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9299878 [details]
Bug 1795698 - Test importing secret key with existing additional public subkey. r=mkmelin

[Triage Comment]
Approved for beta

Comment 10

[Kai Engert [:KaiE:]]

Should get uplifted to esr102 in two weeks

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/3334603659c5
https://hg.mozilla.org/releases/comm-beta/rev/929ac385a1f7

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9298854 [details]
Bug 1795698 - When protecting a secret OpenPGP key, don't assume secret keys for all subkeys are available. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9299878 [details]
Bug 1795698 - Test importing secret key with existing additional public subkey. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 102.6.0:
https://hg.mozilla.org/releases/comm-esr102/rev/60e9056185e2
https://hg.mozilla.org/releases/comm-esr102/rev/ea6f821a1c2d