1795739 - Make it possible to import data from Vivaldi

Status: RESOLVED FIXED

(Firefox :: Migration, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Steps to reproduce:

I tried to import data from another browser.

Actual results:

Vivaldi isn't listed.

Expected results:
Vivaldi should be listed. Probably data format is similar to Chrome, so this is probably not much work.

Comment 1

[Surapunoyousei]

Is someone already working on this? I already have a worked patch, so I wanted to work on it.Chrome and the data format are the same, and even the detection of each profile works without any problems.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Can we see your patch?

Comment 3

[Surapunoyousei]

https://github.com/Floorp-Projects/Floorp/commit/dbf0320c96bec7d5671ee70fbcc1310dfeab24b1

It's mixed, so you'll understand. It's the same as when Brave.

Comment 4

[Surapunoyousei]

It has been built and reported that it is running without any problems.

Comment 5

[Surapunoyousei]

Attachment: vivaldi-migration.png

Reference image after installation.

Comment 6

[Surapunoyousei]

I have verified that it works on all platforms. I believe this patch is can use.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Thanks Surapunoyousei. We'll see if we can merge something like this in. Thanks for the pointers!

Reassigning from Portia to Nolan, as Portia is going to be away for a bit.

Comment 8

[Surapunoyousei]

Attachment: Bug-1795739-Add-import-functionality-from-Vivaldi.patch

Patch that works with Firefox 108 (not tested on Mac/Linux)

Please let me know if there is anything else I should do

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Thanks Surapunoyousei! We'll have one of our CalState LA students work on getting this integrated. Much appreciated!

Comment 10

[Nolan Ishii]

Attachment: Bug 1795739 - Make it possible to import data from Vivaldi. r=mconley

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d52ba94e6d4
Make it possible to import data from Vivaldi. r=mconley,fluent-reviewers,flod

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0d52ba94e6d4

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Thanks for all of your help, Surapunoyousei!

Comment 14

[Daniel Bodea [:danibodea]]

It appears that Nightly v110.0a1 does have the option to import data from Vivaldi, but Beta v109.0b6 does not.
Considering the implementation was pushed to branch 109, it should be there as well, shouldn't it?
This was tested on Mac OS 11 and Windows 10, having the same results.

This situation is the same as with bug 1795462.