Closed Bug 1795777 Opened 2 years ago Closed 1 year ago

Update SeaMonkey website for 2.53.15 beta 1 release

Categories

(SeaMonkey :: Website, task)

Production

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: frg, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.15)

Attachments

(2 files, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #1786134 +++

The usual. Add news download section and release notes.

Assignee: nobody → iannbugzilla
Status: NEW → ASSIGNED
Attachment #9303169 - Flags: review?(frgrahl)
Attachment #9303169 - Flags: feedback?(nunojsg)

Comment on attachment 9303169 [details] [diff] [review]
1795777-website-25315b1.patch

News section looks a bit odd and hacky to me. Otherwise lgtm. r+

I am uploading a followup next.

Attachment #9303169 - Flags: review?(frgrahl) → review+
Attached patch 1795777-addendum-25315.patch (obsolete) — Splinter Review

Rewrote the news section a bit. If you think it is ok I am happy if ypu put it into the main patch. No need for an addendum patch then.

Attachment #9303204 - Flags: review?(iannbugzilla)
Attachment #9303204 - Flags: feedback?(nunojsg)

Comment on attachment 9303204 [details] [diff] [review]
1795777-addendum-25315.patch

Nit: Space between <b> and This update

LGTM, other than a few minor things in the list of changes:

  • In the entry for bug 1410736, there are backticks around "general.useragent.locale", should these be removed?
  • For bug 583677, "visble"->"visible"
  • Is bug 1563959 duplicated?
Attachment #9303169 - Flags: feedback?(nunojsg) → feedback+
Attachment #9303204 - Flags: feedback?(nunojsg) → feedback+
Attached patch 1795777-addendum-1_1-25315.patch (obsolete) — Splinter Review

Added changes based on finding from njsg. f+ retained.

Attachment #9303204 - Attachment is obsolete: true
Attachment #9303204 - Flags: review?(iannbugzilla)
Attachment #9303225 - Flags: review?(iannbugzilla)
Attachment #9303225 - Flags: feedback+

Fix the fix

Attachment #9303225 - Attachment is obsolete: true
Attachment #9303225 - Flags: review?(iannbugzilla)
Attachment #9303226 - Flags: review?(iannbugzilla)
Attachment #9303226 - Flags: feedback+
Attachment #9303226 - Flags: review?(iannbugzilla) → review+
Blocks: 1809340
Blocks: 1817653
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: