1795816 - Ship Array.fromAsync to nightly

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Once Bug 1795452 lands, we'll need to decide when we ship the feature on nightly.

I think a good requirement would be having test262 tests available for it.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Igalia is planning to start on test262 tests soonish, fwiw.

Comment 2

[Hamish Willee]

MDN Tracking bug: https://github.com/mdn/content/issues/22145

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1795816 - Remove Nightly Build guarding around Array.fromAsync in anticipation of train riding r?arai

Depends on D178474

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1795816 - Ship Array.fromAsync r?arai

Depends on D178481

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a05698163bc8
Remove Nightly Build guarding around Array.fromAsync in anticipation of train riding r=arai
https://hg.mozilla.org/integration/autoland/rev/25ce4c12dfca
Ship Array.fromAsync r=arai

Comment 6

[Iulian Moraru]

Backed out for causing multiple failures on test_xrayToJS.xhtml.

• Push with failures

• Failure log

• Backout link

[task 2023-05-23T21:32:38.243Z] 21:32:38     INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | Xrayed instances see proto expandos 
[task 2023-05-23T21:32:38.244Z] 21:32:38     INFO - Buffered messages finished
[task 2023-05-23T21:32:38.245Z] 21:32:38     INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A property on the Array constructor has changed! You need a security audit from an XPConnect peer - got "[\"from\", \"fromAsync\", \"isArray\", \"length\", \"name\", \"of\", \"prototype\"]", expected "[\"from\", \"isArray\", \"length\", \"name\", \"of\", \"prototype\"]"
[task 2023-05-23T21:32:38.246Z] 21:32:38     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:507:14
[task 2023-05-23T21:32:38.246Z] 21:32:38     INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:501:7
[task 2023-05-23T21:32:38.247Z] 21:32:38     INFO - testArray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:648:13
[task 2023-05-23T21:32:38.247Z] 21:32:38     INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:185:5
[task 2023-05-23T21:32:38.247Z] 21:32:38     INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:1:1
[task 2023-05-23T21:32:38.249Z] 21:32:38     INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A symbol-keyed property on the Array constructor has been changed! You need a security audit from an XPConnect peer 
[task 2023-05-23T21:32:38.249Z] 21:32:38     INFO - Running tests for property: Array.from

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c2aa1e8b112
Remove Nightly Build guarding around Array.fromAsync in anticipation of train riding r=arai
https://hg.mozilla.org/integration/autoland/rev/c717912156f5
Ship Array.fromAsync r=arai,peterv

Comment 8

[Atila Butkovits]

Backed out for causing failures at from_async.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/1c427c471f76950cdd4446c672397f205789d3c5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c717912156f584e9cf021cbbe7c9545a7da9748f&selectedTaskRun=YjMX8AZwRU2u5FIOMIbD2g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=417018859&repo=autoland&lineNumber=3884

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7c2aa1e8b112
https://hg.mozilla.org/mozilla-central/rev/c717912156f5

Comment 10

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/763f7f02601be7c0c12b72e92d1b8afd8b759582

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ddd8a91b473
Remove Nightly Build guarding around Array.fromAsync in anticipation of train riding r=arai
https://hg.mozilla.org/integration/autoland/rev/89d5831aba4a
Ship Array.fromAsync r=arai,peterv

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1ddd8a91b473
https://hg.mozilla.org/mozilla-central/rev/89d5831aba4a

Comment 13

[Hamish Willee]

FF115 MDN docs work for this done - essentially just compatibility data update, MDN release note, and removal of experimental tagging on API.
See https://github.com/mdn/content/issues/22145