1795894 - Enable triggering Feature Callouts in chrome by content location

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

When the Feature Callout is rendered in the chrome context, we need to be able to target messages based on the current tab's URL.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1795894 - Enable triggering Feature Callouts in chrome by content location

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2023e8659017
Enable triggering Feature Callouts in chrome by content location r=jprickett

Comment 3

[Marian-Vasile Laza]

Backed out changeset 2023e8659017 (Bug 1795894) for causing multiple bc failures on featureCallout.mjs.
Backout link
Push with failures <--> bc5
Failure Log

Comment 4

[Meg Viar [:mviar]]

Looks like something odd happened when I rebased on autoland. My changes to featureCallout.mjs appear in the phab diff, but not in the diff for the actual landed commit. I'll sort that out and try landing again.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de61491bc549
Enable triggering Feature Callouts in chrome by content location r=jprickett

Comment 6

[Marian-Vasile Laza]

Backed out changeset de61491bc549 (Bug 1795894) for causing bc failures on browser_protocol_ask_dialog.js.
Backout link
Push with failures <--> bc6
Failure Log

Comment 7

[Meg Viar [:mviar]]

Thanks for sharing the failure details - we didn't run into this one on try. I'll work on debugging and discuss with the team if this is a candidate for uplift.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28484915dc1b
Enable triggering Feature Callouts in chrome by content location r=jprickett

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e249e5986d2b35f22c85238281a3ec79a672ce4

Push with failures

Failure log

INFO - Buffered messages finished
[task 2022-11-28T01:42:02.463Z] 01:42:02     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/treeupdate/test_bug1276857.html | uncaught exception - TypeError: can't access property "querySelector", iframe.contentDocument.getElementById(...) is null at runTest_invoke@chrome://mochitests/content/a11y/accessible/tests/mochitest/treeupdate/test_bug1276857.html:42:32
[task 2022-11-28T01:42:02.463Z] 01:42:02     INFO - eventQueue_processNextInvoker@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:485:17

Comment 10

[Meg Viar [:mviar]]

@sandor, I noticed this test failed for a few other runs recently where it was starred as intermittent. As far as I can tell, my changes shouldn't affect the logic in this test and I'm unable to reproduce the failure locally. Here's a try run with that test passing for this patch.

Comment 11

[Sandor Molnar[:smolnar]]

@Meg, indeed it seems the failure is still happening after this backout.
I will reland your patch.
Thank you for looking into this.
Later edit: I saw that you landed some of the files from this bug. You can reland the rest of it too (?).

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1d28e9a3a99b

Comment 13

[Meg Viar [:mviar]]

Thanks, Sandor! I think those other files were the test updates in bug 1802918. That patch has already landed and was set as the parent for this one.

Comment 14

[Simona Rosu [:srosu], Ecosystem QA]

I'm marking this enhancement as verified based on the testing report sent for the "Callout: Pdf annotations for Fx109" bugwork.