Closed Bug 1796000 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36538 - Omit box-shadow at breaks.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36538 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36538
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Omit box-shadow at breaks.

When box-decoration-break is 'slice' (initial value), box-shadows are
expected to be omitted at breaks, both line breaks and fragmentainer
breaks. Add support for this.

This CL is mostly about painting, but I also had to fix a layout bug
in FinishFragmentation(). We used to rely on trailing border/padding
triggering the omission of painting block-end decorations. When this
was just about borders, that approach was fine, but now that we also
have to deal with box shadows, which don't take up space, we need to
make sure block-end stuff gets omitted as long as we haven't reached
the end.

Bug: 682173
Change-Id: Ide22aa3a7f7b275bcf49240923e50201caae8df4

Reviewed-on: https://chromium-review.googlesource.com/3955837
WPT-Export-Revision: bbceb1e1e7ea428a313e435e86c2fab879d847a5

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 1
FAIL: 3

Chrome

PASS: 1
FAIL: 3

Safari

PASS: 3
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/228e77fa0930 [wpt PR 36538] - Omit box-shadow at breaks., a=testonly https://hg.mozilla.org/integration/autoland/rev/2b7e9b1985e6 [wpt PR 36538] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/228e77fa0930
https://hg.mozilla.org/mozilla-central/rev/2b7e9b1985e6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.