1796073 - columnNumber in exceptions and stackTraces should be 0-based

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

Per https://w3c.github.io/webdriver-bidi/#stackframe-column-number

column number

The zero-based column number of the executed code, relative to the start of the line in the resource containing script.

AFAICT we are getting 1-based column and line numbers for our stack traces. We are correctly substracting 1 from our line numbers, but we don't apply the same for column numbers:

• https://searchfox.org/mozilla-central/rev/a64647a2125cf3d334451051491fef6772e8eb57/remote/webdriver-bidi/modules/windowglobal/log.sys.mjs#74,77
• https://searchfox.org/mozilla-central/rev/a64647a2125cf3d334451051491fef6772e8eb57/remote/webdriver-bidi/modules/windowglobal/script.sys.mjs#67,69,75,83

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Interesting. This is most likely an oversight and we should get this fixed. Wasn't there a proposed test change by Maksim regarding the column number? I'm currently not able to find it.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Actually this is https://github.com/web-platform-tests/wpt/pull/36592. The corresponding sync bug is bug 1796800.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1796073 - [remote] Make columnNumber in exceptions and stackTraces 0-based.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b03d3afc321
[remote] Make columnNumber in exceptions and stackTraces 0-based. r=webdriver-reviewers,jdescottes

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5b03d3afc321