Closed Bug 1796079 Opened 3 years ago Closed 3 years ago

-Wstring-conversion warnings in NSS

Categories

(NSS :: Libraries, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

On macOS:

[task 2022-10-19T08:33:59.503Z] 08:33:59    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslmutex.c:616:19: error: implicit conversion turns string literal into bool: 'char[63]' to '_Bool' [-Werror,-Wstring-conversion]
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      PORT_Assert(!("sslMutex_Init not implemented for multi-process applications !"));
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                  ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nss/secport.h:117:21: note: expanded from macro 'PORT_Assert'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  #define PORT_Assert PR_ASSERT
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                      ^
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nspr/prlog.h:208:7: note: expanded from macro 'PR_ASSERT'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      ((_expr)?((void)0):PR_Assert(# _expr,__FILE__,__LINE__))
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -        ^~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslmutex.c:628:19: error: implicit conversion turns string literal into bool: 'char[66]' to '_Bool' [-Werror,-Wstring-conversion]
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      PORT_Assert(!("sslMutex_Destroy not implemented for multi-process applications !"));
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                  ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nss/secport.h:117:21: note: expanded from macro 'PORT_Assert'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  #define PORT_Assert PR_ASSERT
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                      ^
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nspr/prlog.h:208:7: note: expanded from macro 'PR_ASSERT'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      ((_expr)?((void)0):PR_Assert(# _expr,__FILE__,__LINE__))
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -        ^~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslmutex.c:640:19: error: implicit conversion turns string literal into bool: 'char[65]' to '_Bool' [-Werror,-Wstring-conversion]
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      PORT_Assert(!("sslMutex_Unlock not implemented for multi-process applications !"));
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                  ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nss/secport.h:117:21: note: expanded from macro 'PORT_Assert'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  #define PORT_Assert PR_ASSERT
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                      ^
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nspr/prlog.h:208:7: note: expanded from macro 'PR_ASSERT'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      ((_expr)?((void)0):PR_Assert(# _expr,__FILE__,__LINE__))
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -        ^~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslmutex.c:652:19: error: implicit conversion turns string literal into bool: 'char[63]' to '_Bool' [-Werror,-Wstring-conversion]
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      PORT_Assert(!("sslMutex_Lock not implemented for multi-process applications !"));
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                  ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nss/secport.h:117:21: note: expanded from macro 'PORT_Assert'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  #define PORT_Assert PR_ASSERT
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -                      ^
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  /builds/worker/workspace/obj-build/dist/include/nspr/prlog.h:208:7: note: expanded from macro 'PR_ASSERT'
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -      ((_expr)?((void)0):PR_Assert(# _expr,__FILE__,__LINE__))
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -        ^~~~~
[task 2022-10-19T08:33:59.503Z] 08:33:59     INFO -  4 errors generated.
[task 2022-10-19T08:33:59.503Z] 08:33:59    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:590: sslmutex.o] Error 1

On Windows:

[task 2022-10-19T08:35:09.806Z] 08:35:09    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslmutex.c(507,25): error: implicit conversion turns string literal into bool: 'char[44]' to '_Bool' [-Werror,-Wstring-conversion]
[task 2022-10-19T08:35:09.807Z] 08:35:09     INFO -              PR_ASSERT(!("WaitForSingleObject returned invalid value."));
[task 2022-10-19T08:35:09.807Z] 08:35:09     INFO -                        ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-10-19T08:35:09.807Z] 08:35:09     INFO -  /builds/worker/workspace/obj-build/dist/include/nspr/prlog.h(208,7): note: expanded from macro 'PR_ASSERT'
[task 2022-10-19T08:35:09.808Z] 08:35:09     INFO -      ((_expr)?((void)0):PR_Assert(# _expr,__FILE__,__LINE__))
[task 2022-10-19T08:35:09.808Z] 08:35:09     INFO -        ^~~~~
[task 2022-10-19T08:35:09.808Z] 08:35:09     INFO -  1 error generated.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.85
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: