1796122 - Hovered items in main menu bar have wrong color on gtk

Status: RESOLVED DUPLICATE of bug 1790421

(Toolkit :: Themes, defect)

Description

[cobinja]

Attachment: firefox_wrong_foreground_color.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

Hover over main menu items without opening the popup menu.

Regressor is https://hg.mozilla.org/mozilla-unified/rev/dd10e3373b26a3500b4685f6f37b74f32b7fe280, where "appearance: none" was added to menubar:-moz-lwtheme > menu in css. Removing that line fixes this. It worked as expected before that commit.

Actual results:

The hovered item's background color is changed according to the gtk menu item hover background but the foreground color remains unchanged. This is especially noticable with light gtk themes that use a dark menu background (e.g. CobiBird, https://github.com/Cobinja/CobiBird)

Expected results:

Either change the foreground color too according to the used gtk theme or leave the background color unchanged when hovering main menu items without opening the popup (preferred for consistency with pure gtk3 applications like the filemanager nemo).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1785904, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Alex Cornestean]

Hello,

I think I reproduced the issue on the latest Release (106.0.1/20221019185550), Beta (107.0b3/20221020202724) and Nightly (108.0a1/20221020215126) under Ubuntu 22.04.1 LTS.

As per Comment 0, I set the gtk theme to CobiBird via Gnome-Tweaks. I can confirm the gtk theme was applied as all menu backgrounds were dark.

Afterwards I launched Firefox and set the Menu Bar to be visible. On hovering over the menu items, there was no highlighting at all while using the system default browser theme. Only when I set the browser theme to the “Light” one did the highlighting on hover appear on the menu items. This highlighting was indeed the color of the menu backgrounds i.e. the dark grey as seen in the original screenshot.

See the attached screenshot for more details.

I will refrain from changing the status of the issue until I can get a confirmation whether the results I obtained are the ones referred to in Comment 0. Thank you !

Comment 4

[Alex Cornestean]

Attachment: 2022-10-21_11h08_00.png

Comment 5

[cobinja]

I can confirm this only happens when, under "Extensions & Themes", the theme is set to something different than System Theme.
Still, I don't think this should happen, especially in Light and Dark themes where there is no theme-defined custom background image. In my opinion, if colors from the gtk3 theme are used, they should be used as it was intended in gtk3.
Bug 1785904 is related but this is not a duplicate.

Comment 6

[Alex Cornestean]

Hello and thank you for the confirmation !

Based on Comment 3 and Comment 5, I’ll set the issue to New.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1785904