1796280 - -Wunused-* warnings in NSS

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Mike Hommey [:glandium]]

[task 2022-10-19T08:35:39.156Z] 08:35:39    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslsnce.c(253,18): error: unused function 'LaunchLockPoller' [-Werror,-Wunused-function]
[task 2022-10-19T08:35:39.157Z] 08:35:39     INFO -  static SECStatus LaunchLockPoller(cacheDesc *cache);
[task 2022-10-19T08:35:39.157Z] 08:35:39     INFO -                   ^
[task 2022-10-19T08:35:39.157Z] 08:35:39    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/ssl/sslsnce.c(254,18): error: unused function 'StopLockPoller' [-Werror,-Wunused-function]
[task 2022-10-19T08:35:39.158Z] 08:35:39     INFO -  static SECStatus StopLockPoller(cacheDesc *cache);
[task 2022-10-19T08:35:39.158Z] 08:35:39     INFO -                   ^
[task 2022-10-19T08:35:39.158Z] 08:35:39     INFO -  2 errors generated.
[task 2022-10-19T08:38:08.624Z] 08:38:08    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/jar/jarfile.c(758,26): error: unused variable 'attr' [-Werror,-Wunused-variable]
[task 2022-10-19T08:38:08.624Z] 08:38:08     INFO -              unsigned int attr = 0;
[task 2022-10-19T08:38:08.624Z] 08:38:08     INFO -                           ^
[task 2022-10-19T08:38:08.624Z] 08:38:08     INFO -  1 error generated.
[task 2022-10-19T08:38:09.554Z] 08:38:09    ERROR -  /builds/worker/checkouts/gecko/security/nss/cmd/certutil/keystuff.c(47,9): error: variable 'fd' set but not used [-Werror,-Wunused-but-set-variable]
[task 2022-10-19T08:38:09.554Z] 08:38:09     INFO -      int fd;
[task 2022-10-19T08:38:09.554Z] 08:38:09     INFO -          ^
[task 2022-10-19T08:38:09.725Z] 08:38:09    ERROR -  /builds/worker/checkouts/gecko/security/nss/cmd/lib/secpwd.c(29,1): error: unused function 'echoOff' [-Werror,-Wunused-function]
[task 2022-10-19T08:38:09.725Z] 08:38:09     INFO -  echoOff(int fd)
[task 2022-10-19T08:38:09.726Z] 08:38:09     INFO -  ^
[task 2022-10-19T08:38:09.726Z] 08:38:09    ERROR -  /builds/worker/checkouts/gecko/security/nss/cmd/lib/secpwd.c(42,1): error: unused function 'echoOn' [-Werror,-Wunused-function]
[task 2022-10-19T08:38:09.726Z] 08:38:09     INFO -  echoOn(int fd)
[task 2022-10-19T08:38:09.726Z] 08:38:09     INFO -  ^
[task 2022-10-19T08:38:09.726Z] 08:38:09     INFO -  2 errors generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1796280 - Fix -Wunused-{function,variable,but-set-variable} warnings on Windows.

Comment 2

[Mike Hommey [:glandium]]

I missed another on Windows aarch64:

[task 2022-10-19T08:57:30.070Z] 08:57:30    ERROR -  /builds/worker/checkouts/gecko/security/nss/lib/freebl/blinit.c(146,24): error: unused variable 'getauxval' [-Werror,-Wunused-variable]
[task 2022-10-19T08:57:30.070Z] 08:57:30     INFO -  static unsigned long (*getauxval)(unsigned long) = NULL;
[task 2022-10-19T08:57:30.070Z] 08:57:30     INFO -                         ^
[task 2022-10-19T08:57:30.070Z] 08:57:30     INFO -  1 error generated.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/projects/nss/rev/de8c80461d8de35a8809eea4b51393e8c3e163c2