1796315 - Fixes to get Dart programs working

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1796315 - wasm: Fix assert in UnsetLocalsState. r?yury

This assert should be checking WordBits, not WordSize.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1796315 - wasm: Standardize iteration of struct/array new instructions. r?jseward

This commit:

• Uses a consistent style of iterating backwards over struct fields
• Changes array.new_fixed in baseline to init backwards, aligning with InitExpr and V8
• Fixes WAO::fillVal when itemIndex != 0 (a latent bug, not triggerable)

Depends on D159793

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1796315 - wasm: Fix recursion group prefix byte. r?yury

This fixes it to use the one in V8's milestone 6. For sanity
sake we keep allowing the version used by wasm-tools, and will
remove it once we do our next update.

Depends on D159794

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1796315 - wasm: Remove 'private reftypes' and allow non-nullable globals. r?yury

This commit remove WASM_PRIVATE_REFTYPES which is from the original prototype
that Lars wrote. It's not been needed since we added 'isExposable' to prevent
certain wasm values such as V128 from going to JS, and used that for GC
values.

This commit also removes the restriction on non-nullable globals. The
globals JS-API supports non-nullable globals, and the internal
wasm type system should ensure all globals are initialized to
non-null.

As a drive-by, the table.get() JS-API was updated to not work when the
table has a non-exposable value type.

Depends on D159795

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rhunt, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44c02e32758a
wasm: Fix assert in UnsetLocalsState. r=yury
https://hg.mozilla.org/integration/autoland/rev/e55a4f46bac7
wasm: Standardize iteration of struct/array new instructions. r=jseward
https://hg.mozilla.org/integration/autoland/rev/16155d6f04ef
wasm: Fix recursion group prefix byte. r=yury
https://hg.mozilla.org/integration/autoland/rev/567762af5c3f
wasm: Remove 'private reftypes' and allow non-nullable globals. r=yury

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/44c02e32758a
https://hg.mozilla.org/mozilla-central/rev/e55a4f46bac7
https://hg.mozilla.org/mozilla-central/rev/16155d6f04ef
https://hg.mozilla.org/mozilla-central/rev/567762af5c3f