1796356 - PromptFeature refactoring

Status: NEW

(Firefox for Android :: Browser Engine, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/android-components/issues/10323.

Following https://github.com/mozilla-mobile/android-components/issues/8989 and https://github.com/mozilla-mobile/android-components/pull/10273 it was seen that there are some situations which can be better handled.

Most of these situations are to the activePrompt - what that should represent and how should that be updated. Currently it can be initialized or cleared without a new Prompt being displayed / dismissed and can remain cleared with other Prompts displayed.

Things to consider:

• unify dialogs and pickers under a single interface
• keep a list of prompts (and pickers) / have a way of getting all of them in PromptFeature in the order shown on screen
• have an easy way to map Prompts to PromptRequests and reverse
  • so that when one such Prompt is consumed by the user the PromptRequest for which it was shown can be removed form the Session and can be sent to GV to be consumed.
• decide what should happen from an UX standpoint if the user is actively interacting (what should this mean?) with a Prompt and a new PromptRequest comes
  Currently all Prompts are modals with new Prompts stacked on top of each other (not sure how common is to get more Prompts but it definitely happens)
• since now prompts are consumed by uid maybe consuming them by tab can be deprecated.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.