1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r?mossop

It's now clear when there is no log modules enabled.

Depends on D160209

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1796554 - Make it explicit when there's no log file set. r?mossop

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad76f060c8f
Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
https://hg.mozilla.org/integration/autoland/rev/cd729b6a5864
Make it explicit when there's no log file set. r=mossop,flod

Comment 4

[Marian-Vasile Laza]

Backed out 9 changesets (Bug 1796554, Bug 1800076, Bug 1796152, Bug 1797497, Bug 1802349, Bug 1797284, Bug 1796585) for causing build bustages.
Backout link
Push with failures <--> B
Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e3b50d9b36c
Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
https://hg.mozilla.org/integration/autoland/rev/aa2e24236a3c
Make it explicit when there's no log file set. r=mossop,flod

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in toolkit/content/tests/browser/browser_about_logging.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/3ca181bf09815a901ba7d7ca9a5fe98c6d099537

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e73defde7d21
Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
https://hg.mozilla.org/integration/autoland/rev/5963545fcfaf
Make it explicit when there's no log file set. r=mossop,flod

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 9 changesets (Bug 1796585, Bug 1797497, Bug 1800076, Bug 1796152, Bug 1802349, Bug 1797284, Bug 1796554) for causing failures in browser_about_logging.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=1155668&selectedTaskRun=WCYAvoHeTySKbf985ORDxg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Ctsan%2Copt%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux1804-64-tsan-qr%2Fopt-mochitest-browser-chrome-swr%2Cbc10&revision=5d578b36aea086094edf4f9813027ac32cfd66c4

Log: https://treeherder.mozilla.org/logviewer?job_id=398817848&repo=autoland&lineNumber=4269

Backout: https://hg.mozilla.org/integration/autoland/rev/c9511a6efe62364862f7502bd8d1636a0f65b41d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc1c2ffbc38e
Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
https://hg.mozilla.org/integration/autoland/rev/e3534e639e2c
Make it explicit when there's no log file set. r=mossop,flod

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in xpcom/base/nsTraceRefcnt.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/6212248e60a47a7a019b2e46c5089172dadbca52

Push with failures

Failure log

INFO - GECKO(3245) | Assertion failure: false (Tried and failed to create an XPCOM log), at /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp:564

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c34b1f0c38d
Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
https://hg.mozilla.org/integration/autoland/rev/5a7335c01b22
Make it explicit when there's no log file set. r=mossop,flod

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4c34b1f0c38d
https://hg.mozilla.org/mozilla-central/rev/5a7335c01b22