1796559 - Right clicking on the extensions icon in toolbar will open the page alongside the dropdown menu

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Found in

• Firefox 108.0a1

Affected versions

• Firefox 108.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13, Ubuntu 22.04
• Unaffected platforms:

Steps to reproduce

1. Launch Firefox
2. Right click over the Extensions icon from the toolbar

Expected result

• The right click dropdown menu is launched

Actual result

• The extension page is opened along with the right click dropdown menu

Regression range

• Will see for a regression if there is one. The extensions icon was recently added in Nightly 108 by default in toolbar.

Additional notes

• The issue can be seen in the following attachment
• The issue will not reproduce on older builds if the icon is manually dragged to toolbar.

Comment 1

[Alex Cornestean]

I performed a mozregression ranging from the date Nightly 108 was released (2022-10-17) until today and all builds are affected.

Mozregression found a regressor, but it’s certainly a false positive. Nevertheless, I’ll put it here:
2022-10-25T11:00:35.399000: DEBUG : Found commit message:
Bug 1795595 - [devtools] Add 'Copy as PowerShell' command to request list context menu r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D157711

The issue was certainly introduced with the implementation of the unified extensions button and most likely not a regression.

Comment 2

[William Durand [:willdurand]]

I'll take a look.

Comment 3

[William Durand [:willdurand]]

Attachment: Bug 1796559 - Only open about:addons on primary click. r?zombie!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08eed030188f
Only open about:addons on primary click. r=zombie

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/08eed030188f

Comment 6

[Alex Cornestean]

Verified as Fixed on the latest Nightly (108.0a1/20221102174350). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

Right clicking the extension button will open the right click menu and not about:addons, confirming the fix. Left clicking will open about:addons as before and as intended.

For more details, see the attached video. The video depicts several right clicks on the extension button which opens the right click menu and one left click which opens about:addons as intended.

Comment 7

[Alex Cornestean]

Attachment: 2022-11-03_08h19_43.mp4