Closed Bug 1796797 Opened 2 years ago Closed 1 year ago

Convert toolkit/components/contextualidentity JSM modules to ESMs

Categories

(Toolkit :: General, task)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox108 --- wontfix
firefox109 --- wontfix
firefox110 --- fixed

People

(Reporter: sdk, Assigned: sdk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → contact
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3f2a6e9bf80e
Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku

Backed out for causing bc failures on ContextualIdentityService.jsm.

Push with failures

Failure log
Failure log 2

Backout link

[task 2022-11-09T20:07:20.652Z] 20:07:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | denylist entry resource://gre/modules/Bookmarks.sys.mjs for phase "before handling user events" must exist - 
[task 2022-11-09T20:07:20.653Z] 20:07:20     INFO - TEST-INFO | started process screentopng
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - TEST-INFO | screentopng: exit 0
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - Buffered messages logged at 20:07:19
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - Entering test bound 
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - Buffered messages finished
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup.js | denylist entry resource://gre/modules/ContextualIdentityService.jsm for phase "before handling user events" must exist - 
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - Stack trace:
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - chrome://mochikit/content/browser-test.js:test_ok:1457
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup.js:null:232
[task 2022-11-09T20:07:20.873Z] 20:07:20     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup.js | denylist entry resource://gre/modules/FxAccounts.jsm for phase "before handling user events" must exist - 
Flags: needinfo?(contact)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sdk, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(contact)
Flags: needinfo?(amarchesini)
Flags: needinfo?(contact)
Flags: needinfo?(amarchesini)
Flags: needinfo?(contact)
Attachment #9299672 - Attachment description: Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku → Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12ac36bd13de
Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku,webdriver-reviewers,extension-reviewers,settings-reviewers,robwu
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

See Also: → 1808165
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: