1796893 - build failure on OpenBSD/arm64 since ffmpeg config regen in bug 1765480

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Landry Breuil (:gaston)]

106 failed to build on OpenBSD/arm64, cf http://build-failures.rhaalovely.net/aarch64/2022-10-18/www/mozilla-firefox.log (13Mb):

In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavcodec/aarch64/fft_init_aarch64.c:27:
In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavcodec/fft.h:32:
In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavutil/mem_internal.h:29:
In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavutil/mem.h:34:
In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavutil/avutil.h:296:
In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavutil/common.h:575:
In file included from /usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavutil/internal.h:43:
/usr/obj/ports/firefox-106.0/firefox-106.0/media/ffvpx/libavutil/timer.h:37:11: fatal error: 'asm/unistd.h' file not found
# include <asm/unistd.h>
          ^~~~~~~~~~~~~~
1 error generated.
gmake[3]: *** [/usr/obj/ports/firefox-106.0/firefox-106.0/config/rules.mk:590: fft_init_aarch64.o] Error 1
gmake[3]: Leaving directory '/usr/obj/ports/firefox-106.0/build-aarch64/media/ffvpx/libavcodec/aarch64'
gmake[2]: *** [/usr/obj/ports/firefox-106.0/firefox-106.0/config/recurse.mk:72: media/ffvpx/libavcodec/aarch64/target-objects] Error 2

this was tracked down by theo buehler to be caused by toggling of #define CONFIG_LINUX_PERF to 1 in https://hg.mozilla.org/mozilla-central/rev/c174bd2624e2d4fc41721a5a51a48fbeae1666c2#l2.616

for some reason this doesnt blow on amd64, but there's no asm/unistd.h on OpenBSD.

Comment 1

[Theo Buehler]

The reason it only fails on aarch64 is that the config file changed is media/ffvpx/config_unix_aarch64.h which given its name isn't used on other architectures. The only other two config files containing CONFIG_LINUX_PERF 1 are config_android{32,64}.h, where this setting probably makes sense.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1765480

:padenot, since you are the author of the regressor, bug 1765480, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Paul Adenot (:padenot)]

Yeah we can remove this, I think I had the perf headers installed on the linux box where I regenerated those. We can revert this to 0 and I'll update the documentation so hopefully it doesn't happen again.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1796893 - Fix build failure on OpenBSD/arm64 since ffmpeg config regen in bug 1765480. r?alwu

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 9299857 [details]
Bug 1796893 - Fix build failure on OpenBSD/arm64 since ffmpeg config regen in bug 1765480. r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: This breaks downstream builds, on various BSDs aarch64.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is tier-3, but absolutely trivial to uplift, doesn't affect our builds, and fixes the build for downstream.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e9a8dd87c72
Fix build failure on OpenBSD/arm64 since ffmpeg config regen in bug 1765480. r=alwu

Comment 7

[Landry Breuil (:gaston)]

and fwiw this has already been commited downstream to fix 106 on OpenBSD/ar64 in https://marc.info/?l=openbsd-ports-cvs&m=166643684911831&w=2

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2e9a8dd87c72

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9299857 [details]
Bug 1796893 - Fix build failure on OpenBSD/arm64 since ffmpeg config regen in bug 1765480. r?alwu

Approved for 107.0b6.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0cc41f6083f9