1796917 - Parenthesis error in nspr/pr/src/pthreads/ptsynch.c

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Svante Signell]

Attachment: nspr_pr_src_pthreads_ptsynch.c.diff

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Build on GNU/Hurd

Actual results:

ptsynch.c:55:48: error: ‘PTHREAD_MUTEX_ADAPTIVE_NP’ undeclared (first use in this function);

Expected results:

This code should not be activated
rv = pthread_mutexattr_settype(&_pt_mattr, PTHREAD_MUTEX_ADAPTIVE_NP);

This is due to an error in the condition:
#if (defined(LINUX) && (GLIBC > 2) || (GLIBC == 2 && GLIBC_MINOR >= 2))...
The second applies to all systems defining glibc>=2.2. It was probably meant to include the condition on LINUX too. The attached patch fixes this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:KaiE, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Svante Signell]

ping?

Comment 3

[Kai Engert [:KaiE:]]

Thanks for your patch. Your patch seems reasonable.
I'll commit your patch to NSPR. It might take a while (months) until it's released.

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9299742 [details] [diff] [review]
nspr_pr_src_pthreads_ptsynch.c.diff

r=kaie

Comment 5

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nspr/rev/e4dd811a812cb923ae36ea077220758c26de4ba9