1796964 - If login to news server fails, username is missing from the error message

Status: RESOLVED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[b4]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

Steps to reproduce:

If login to news server fails, username is missing from the error message:
Login to server news.eternal-september.org with username <missing> failed.

To test: Create an account at eternal-september.org, which requires authentication. After successful initial connection, edit the password in the password manager to simulate the error condition.

TB 107 beta. Could be a regression of recent bugs in this area (for example bug 1770594).

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1796964 - Show username in auth failure dialog in nntp-js. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1fbdf0366d0f
Show username in auth failure dialog in nntp-js. r=mkmelin

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9300099 [details]
Bug 1796964 - Show username in auth failure dialog in nntp-js. r=mkmelin

[Triage Comment]
Approved for beta

[Approval Request Comment]
Regression caused by (bug #): 1770594/nntp-js
User impact if declined: Missing username from NNTP login error messages
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low, adding information for display

Comment 4

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/683045dd2a43

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9300099 [details]
Bug 1796964 - Show username in auth failure dialog in nntp-js. r=mkmelin

[Triage Comment]
Approved for esr102

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/0f228970d79c