Panel subview subheaders are too tall
Categories
(Core :: Layout, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: aminomancer, Assigned: emilio)
References
Details
Attachments
(1 file)
STR
- Click the hamburger button to open the app menu
- Click the history subview button
- In the history subview, look at the "Recent history" title
Expected
Content box should be like 14-16px tall with 4px block padding, so bounding box should be total 22-24px height (depending on OS fonts I believe)
Actual
Content box is 24px tall with 4px block padding, 32px total
I expect this is bc of the modern flexbox changes. Anyway, adding box-sizing: border-box fixes it. Setting min-height: 0 also makes it smaller, but on my system it produces 13.33px content box height instead of 16x. Idk if there's a more tailored solution to these kinds of issues
|
Assignee | |
Comment 1•2 years ago
|
||
The right fix is using box-sizing: border-box. XUL didn't understand box-sizing: content-box and always used the border-box.
|
|
Assignee | |
Comment 2•2 years ago
|
||
We know respect box-sizing. Also, remove -moz-box display declaration
which is no longer needed (it was due to a bad interaction between block
and XUL layout, see bug 1695617).
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e83c56bea11 Use border-box sizing for panel subview headers. r=Gijs
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•