Closed
Bug 1797009
Opened 2 years ago
Closed 2 years ago
Extract common operation when reporting line-break-before status, and use PushTruncatedLine() more
Categories
(Core :: Layout: Block and Inline, task)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(2 files)
In nsBlockFrame, we have duplicate code doing the same thing when ShouldAvoidBreakInside is true [1] [2] [3]. We should aggregate them in a function.
[1] https://searchfox.org/mozilla-central/rev/b8493b02562426c78f8213284ea5ce9713ed96a4/layout/generic/nsBlockFrame.cpp#3912-3913
[2] https://searchfox.org/mozilla-central/rev/b8493b02562426c78f8213284ea5ce9713ed96a4/layout/generic/nsBlockFrame.cpp#4160-4161
[3] https://searchfox.org/mozilla-central/rev/b8493b02562426c78f8213284ea5ce9713ed96a4/layout/generic/nsBlockFrame.cpp#4334-4337
|
Assignee | |
Comment 1•2 years ago
|
||
This patch doesn't change behavior.
|
||
Updated•2 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/cdd7e5bc5f74 Extract common operation when reporting line-break-before status, and use PushTruncatedLine() more. r=emilio
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3b869892fe8f Use PushTruncatedLine() once more. r=layout-reviewers,emilio
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•