179701 - User watching should include email for the watched user's flag requests

Status: NEW

(Bugzilla :: Attachments & Requests, defect)

Description

[timeless]

timeless@<somewhere> just got a real review request. i haven't seen any bugmail
for the review request itself, and i don't believe i will. (there are other bugs
about the fact that the review request itself is unitelligable, i'd like to be
cc'd on those but i'm happy just knowing they exist.)

all i have is this:
http://bugzilla.mozilla.org/show_bug.cgi?id=113202
[e-mail] changed:
           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94708 [details] [diff]|                            |review?(timeless),

This nearly blocks my bugmail shadowing based development. so that's the
severity i'm selecting.

what i want:
watchers (eg me) should get a coy of requests to watchees (in this case
'timeless', whomever that may be). ideally this will be fixed so that a watchee
can actually interpret the message, again i don't know the bug number but i'm
confident it exists and will be fixed eventually.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Not a blocker for most people's use of the system.

Comment 2

[Ed Morley [:emorley]]

(Tweaking summary to make it a bit more keyword rich, after missing this first time around :-))

Comment 4

[Peter Jackson]

(In reply to Ed Morley [:edmorley UTC+0] from comment #2)
> (Tweaking summary to make it a bit more keyword rich, after missing this
> first time around :-))

Be nice if the word "flags" appeared in the summary also, I think.

How about:

Watching a user does not include email for flag requests

Or

User watching should include email for the watched user's flag requests

??

Comment 5

[Ed Morley [:emorley]]

Good suggestion, thank you :-)

Comment 6

[Peter Jackson]

A workaround that may work for some use cases, mostly where the user being watched is not a real person, and exists mostly to be watched.

1. Add the user to the CC list when the flag is set for them.
2. Remove the user from the CC list when the flag is cleared for them.

In our Bugzilla instance, there is a preference "Automatically add me to the CC list of bugs I am requested to review" (Hmm, and this Bugzilla too, but I don't see it in the online documentation for the General Preferences tab).

The remove at the end required using the bug_start_of_update hook / callback for custom code.

Obviously this doesn't work if the user is required to be a CC of the bug for other reasons, they'll get removed when the request is resolved. You could probably work around that with "hidden" information in the database, or using multiple accounts, but I'll leave that as an exercise for the reader, since it is starting to feel pretty fragile.

Comment 7

[Ed Morley [:emorley]]

The sheriffs have an account that each team member watches ([e-mail]), and people quite like needinfo'ing this account (latest example in bug 1055876). Thanks to the "CC me when a request is made" setting, we do get _some_ email, but it's easily lost in the noise vs a flag that triggers reminders, has a more obvious email subject etc.