1797058 - Make "Phrase not found" and insecure connection warning text bold

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Dão Gottwald [:dao]]

from bug 1794369 comment 12:

(In reply to Itiel from comment #11)

(In reply to Amy Churchwell [:amy] from comment #9)

FYI: we also seem to be using this error color-mix in a couple of other places such as, panel.css (identity panel) and print.css --
https://searchfox.org/mozilla-central/search?q=color-mix(in+srgb%2C+currentColor+40%25%2C+%23C50042)&path=&case=false&regexp=false

btw specifically for the print popup it doesn't matter as we use common-shared.css there, and webext themes can't affect how it'd look. We cater only for light and dark mode so this isn't an issue there.

How about drop the color and make text bold instead to keep the emphasis for the find bar and the site identity panel? I feel like just dropping the color without a replacement isn't that great as the emphasis serves a purpose in both cases.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1797058 - Make "Phrase not found" and insecure connection warning text bold. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64af71113f69
Make "Phrase not found" and insecure connection warning text bold. r=sfoster

Comment 3

[Cristian Tuns]

Backed out for causing browser-chrome failures on /browser_parsable_css.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property --error-text-color is not referenced -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/989a0ce83246
Make "Phrase not found" and insecure connection warning text bold. r=sfoster

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/989a0ce83246