1797146 - Unexpected spaces in serialization of `font-variant` when a system font name is used

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Kew [:jfkthame]]

Using a new about:blank window,

> var s = document.body.style
< CSS2Properties(0)
> s.font = "menu"
< "menu"
> s.fontVariant
< "     "

expected: "", got: "     "

> s.fontVariantNumeric = "tabular-nums"
< "tabular-nums"
> s.fontVariant
< "    tabular-nums "

expected: "tabular-nums", got: "    tabular-nums "

> s.fontVariantCaps = "small-caps"
< "small-caps"
> s.fontVariant
< "small-caps    tabular-nums "

expected: "small-caps tabular-nums", got "small-caps    tabular-nums "

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1797146 - Add a WPT test for serialization of font-variant. r=#firefox-style-system-reviewers

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1797146 - Fix serialization of font-variant when using a system font keyword. r=#firefox-style-system-reviewers

Depends on D160110

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1797146 - Remove system font support for various font longhands. r=jfkthame

We don't use them1, and these are generally not properties that
authors would be able to set via the font shorthand anyways.

Let's simplify the code. This fixes the font-variant bug and also
unblocks further clean-ups of these properties in the future.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/276b26a8ddb0
Remove system font support for various font longhands. r=jfkthame

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69dc8f8cf2e5
Add a WPT test for serialization of font-variant. r=emilio

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36671 for changes under testing/web-platform/tests

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/276b26a8ddb0
https://hg.mozilla.org/mozilla-central/rev/69dc8f8cf2e5

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot