Open Bug 1797150 Opened 2 years ago Updated 5 months ago

[Automated review] Do we need performance-noexcept-move-constructor clang-tidy warning?

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: TYLin, Unassigned)

Details

Phabricator URL: https://phabricator.services.mozilla.com/D160014?id=637933#5251767

Per emilio's review comments, we build gecko without C++ exception, so performance-noexcept-move-constructor lint is probably not very useful.

This has been previously considered, and the answer is probably "yes, we do need it". See bug 1612680 and related bugs for details.

You need to log in before you can comment on or make changes to this bug.