1797157 - Fix third_party/libwebrtc base-toolchains build error for missing std::launder

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Michael Froman [:mjf]]

See: https://treeherder.mozilla.org/jobs?repo=elm&selectedTaskRun=FIW8FSDSTBiNbE-MekVo-Q.0

This build error started after importing upstream's 4b97928b30. It begins using absl::AnyInvocable which is trying to use std::launder.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1797157 - Avoid std::launder under clang++ 5 even in c++17 mode. r?mjf

std::launder was implemented in clang 6:
https://github.com/llvm/llvm-project/commit/9180eb1f4ab96481413e93d35f35c3685de3084c

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

I have filed this patch upstream: https://github.com/abseil/abseil-cpp/issues/1309 .

Comment 3

[Andreas Pehrson [:pehrsons]]

https://hg.mozilla.org/projects/elm/rev/96651601f2e2d98fe2d6478c73000e320b62d24b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/02a5dcbbd7ee
Avoid std::launder under clang++ 5 even in c++17 mode. r=mjf

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/02a5dcbbd7ee