1797216 - Upgrade cctools-port and libtapi

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1797216 - Upgrade cctools-port and libtapi.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c6ca8281c31
Upgrade cctools-port and libtapi. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1c6ca8281c31

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing jit-1-proc failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/3ef6f704118918719eb6da9520b5f6b1f24d313d

Push with failures

Failure log

Comment 5

[Marian-Vasile Laza]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/3ef6f704118918719eb6da9520b5f6b1f24d313d

Comment 6

[Andra Esanu (needinfo me)]

(In reply to Sandor Molnar from comment #4)

Backed out for causing jit-1-proc failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/3ef6f704118918719eb6da9520b5f6b1f24d313d

Push with failures

Failure log

== Change summary for alert #35838 (as of Fri, 28 Oct 2022 08:44:17 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	installer size	osx-aarch64-shippable	aarch64 nightly	81,996,873.88 -> 83,156,459.58
1%	installer size	osx-aarch64-shippable	aarch64 nightly	82,037,731.92 -> 83,165,105.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35838

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1797216 - Update cctools-port and libtapi. r=#build!

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Mike, could I get some help to get this over the finish line? Right now it's very close, but it seems we need some more modern libstdc++ / libc++ in the toolchain sysroot to build cctools, since it uses std::span and that doesn't exist there.

I had worked around this in libtapi since it only needed <version> (see libtapi.patch), but I'd rather not have to bundle a <span> port...

Comment 10

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&revision=7d81bf4af8df9152431dca4065b121a59d989b82&selectedTaskRun=YfkI4pa1T9qCgxBotB9tqQ.0 is a try run with the current state

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Ah, the gcc10 sysroot does have a new enough standard library.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

https://perf.compare/compare-lando-results?baseLando=155182&newLando=155183&baseRepo=try&newRepo=try&framework=13
Base revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=155182
Local revision's try run: https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=155183

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=155185

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a7ddd39183f
https://hg.mozilla.org/integration/autoland/rev/51c917371b2c
Update cctools-port and libtapi. r=firefox-build-system-reviewers,glandium

Comment 14

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/51c917371b2c