1797393 - Split and robustify browser text tests

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Eitan Isaacson [:eeejay]]

browser_caching_text.js is a sprawling mess, there are also a couple of intermittent failures in there when caching is on.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1797393 - P1: Split and rename browser text tests. r=Jamie

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1797393 - P2: Robustify spelling error text test. r=Jamie

Layout can trigger several text attribute changed events. We need to
wait until we get the correct one before continuing the test.

Depends on D160299

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1797393 - P3: Explicitly assign font name to text area in linebreak test. r=Jamie

For some reason the default monospace font in Linux is not actually
monospaced and a linebreak is not guaranteed.

Depends on D160300

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c0193df13d2
P1: Split and rename browser text tests. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/a833abbbc1a7
P2: Robustify spelling error text test. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/92b3f4f74412
P3: Explicitly assign font name to text area in linebreak test. r=Jamie

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in accessible/tests/browser/e10s/browser_text_caret.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b059d0bcdfb0690292ff654acfdaf5233064ae86

Push with failures

Failure log

INFO - Buffered messages finished
[task 2022-10-28T19:31:14.731Z] 19:31:14     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/e10s/browser_text_caret.js | getTextAtOffset (word start): wrong text (got '', expected: 'cd '), offset: -2, id: [DOM node id: textarea, role: entry, address: [xpconnect wrapped (nsIAccessible, nsIAccessibleText)]]; - 
[task 2022-10-28T19:31:14.731Z] 19:31:14     INFO - Stack trace:

Comment 6

[Eitan Isaacson [:eeejay]]

Adding spellcheck=false to the textarea fixes the caret test. the failures were caused by spelling error range changes and us being mid-reflow. When I added a new font I introduced this issue because the need for a reflow depends on the font and its underline size.. https://searchfox.org/mozilla-central/source/layout/generic/nsTextFrame.cpp#7793

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f811739c8d0
P1: Split and rename browser text tests. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/ec63c426aaba
P2: Robustify spelling error text test. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/8094a5d40dab
P3: Explicitly assign font name to text area in linebreak test. r=Jamie

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f811739c8d0
https://hg.mozilla.org/mozilla-central/rev/ec63c426aaba
https://hg.mozilla.org/mozilla-central/rev/8094a5d40dab