Closed Bug 1797441 Opened 3 years ago Closed 2 years ago

[rust 1.66] error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`

Categories

(Firefox Build System :: Toolchains, defect)

Product:
Firefox Build System
Component:
Toolchains
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glandium, Unassigned)

References

Details

Linux TSAN build fails with rustc 1.66:

[task 2022-10-26T05:37:51.943Z] 05:37:51     INFO -  error: failed to resolve patches for `https://github.com/rust-lang/crates.io-index`
[task 2022-10-26T05:37:51.943Z] 05:37:51     INFO -  Caused by:
[task 2022-10-26T05:37:51.944Z] 05:37:51     INFO -    patch for `cfg-if-0.1.10` in `https://github.com/rust-lang/crates.io-index` failed to resolve
[task 2022-10-26T05:37:51.944Z] 05:37:51     INFO -  Caused by:
[task 2022-10-26T05:37:51.944Z] 05:37:51     INFO -    The patch location `/builds/worker/fetches/rustc/lib/rustlib/src/rust/vendor/cfg-if-0.1.10` does not appear to contain any packages matching the name `cfg-if-0.1.10`.

This suggests some recent cargo change broke our patch from build/build-rust/cargo-vendor-std.patch.

The patch we use for cargo is based on https://github.com/rust-lang/cargo/pull/8834, which says "Note that this design naively assumes there is only one version of each package. It does not robustly verify this, and will presumably just cryptically fail to resolve dependencies.". Well, there are now two versions of cfg-if, and we're getting a cryptic failure :)

This had been worked around in bug 1797419, and rust 1.67 is back to only one version of cfg-if.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.