Crash in [@ mozilla::gfx::FeatureState::Instance::IsInitialized]
Categories
(Core :: Graphics, defect)
Tracking
()
People
(Reporter: aryx, Assigned: sotaro)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-beta+
pascalc
:
approval-mozilla-release+
|
Details | Review |
~260 crashes from 220 installations of Firefox 106.0 and 106.0.1, all on Windows. No crashes for earlier versions.
Occlusion is mentioned in the stack. sotaro, could you take a look at these crashes? Thank you in advance.
Crash report: https://crash-stats.mozilla.org/report/index/88df4472-86b4-48d3-b5f4-d56620221025
Reason: EXCEPTION_ACCESS_VIOLATION_READ
Top 10 frames of crashing thread:
0 xul.dll mozilla::gfx::FeatureState::Instance::IsInitialized const gfx/config/gfxFeature.h:134
0 xul.dll mozilla::gfx::FeatureState::IsInitialized const gfx/config/gfxFeature.h:121
0 xul.dll mozilla::gfx::FeatureState::IsEnabled const gfx/config/gfxFeature.cpp:17
0 xul.dll mozilla::gfx::gfxConfig::IsEnabled gfx/config/gfxConfig.cpp:25
1 xul.dll nsWindow::MaybeEnableWindowOcclusion widget/windows/nsWindowGfx.cpp:407
1 xul.dll nsWindow::DestroyCompositor widget/windows/nsWindowGfx.cpp:458
2 xul.dll nsWindow::Destroy widget/windows/nsWindow.cpp:1273
3 xul.dll mozilla::AppWindow::Destroy xpfe/appshell/AppWindow.cpp:659
4 xul.dll mozilla::AppWindow::~AppWindow xpfe/appshell/AppWindow.cpp:154
5 xul.dll mozilla::AppWindow::Release xpfe/appshell/AppWindow.cpp:162
Updated•2 years ago
|
Updated•2 years ago
|
Comment 2•2 years ago
|
||
Sotaro, given that this is a startup crash, I would probably take a patch in a 106 dot release if we find a fix, ideally before we hit RC week for 107.
Assignee | ||
Comment 3•2 years ago
|
||
On nightly, majority of crashes seemed to happen in nsAppShellService::JustCreateTopWindow() like the following.
When the crash happened, AppWindow was destroyed in nsAppShellService::JustCreateTopWindow(). The JustCreateTopWindow() seemed to return early at NS_ENSURE_SUCCESS() or NS_ENSURE_TRUE().
Assignee | ||
Comment 4•2 years ago
•
|
||
If first AppWindow is destroyed in nsAppShellService::JustCreateTopWindow() because of error, the first window could be destroyed before calling gfxConfig::Init().
gfxConfig::Init() is called from gfxPlatform::GetPlatform(). gfxPlatform::GetPlatform() is called just before creating compositor by nsBaseWidget::CreateCompositor()
And during destroying the AppWindow, nsWindow::Destroy() is called. Then it calls nsWindow::DestroyCompositor(). gfxConfig::IsEnabled() is called be before gfxConfig::Init().
Assignee | ||
Comment 5•2 years ago
|
||
Comment 7•2 years ago
|
||
bugherder |
Comment 8•2 years ago
|
||
Sotaro, could you request uplift for beta and release please? If it proves to work in 107 beta 7 we may still have time to ship it in a 106 dot release next week. Thanks.
Assignee | ||
Comment 10•2 years ago
•
|
||
Comment on attachment 9300485 [details]
Bug 1797464 - Enable/disable window occlusion only when compositor session exists on Windows
Beta/Release Uplift Approval Request
- User impact if declined: startup crash could happen when Firefox fails to start.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The patch just add mCompositorSession check.
- String changes made/needed: none
- Is Android affected?: No
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Comment on attachment 9300485 [details]
Bug 1797464 - Enable/disable window occlusion only when compositor session exists on Windows
Approved for 107.0b7.
Comment 12•2 years ago
|
||
bugherder uplift |
Comment 13•2 years ago
|
||
Comment on attachment 9300485 [details]
Bug 1797464 - Enable/disable window occlusion only when compositor session exists on Windows
Approved for 106.0.3, thanks.
Comment 14•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Description
•