1797730 - Developer Tools open in a separate window does not automatically close when Firefox is quit

Status: VERIFIED FIXED

(DevTools :: General, defect, P2)

Description

[Ben]

Steps to reproduce:

Open Developer Tool in Separate Window mode. Quit Firefox.

Actual results:

Firefox browser quits. Developer Tools remains open (and active?). Re-opening Firefox then breaks the Developer Tools functionality/use.

Expected results:

Developer Tools (open in Separate Window) closes when Firefox quits

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

We can reproduce on Linux in 108
Bug wasn't there on 105.

We need a regression window.
We'll investigate and try to fix it soon

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

This is probably a regression from bug 1700909.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1700909

Comment 4

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1797730 - [devtools] Fix typo preventing to close devtools on browser toolbox closing.

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1797730 - [devtools] Rename gDevTools._toolboxes to gDevTools._toolboxesPerCommands.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab24053acb84
[devtools] Fix typo preventing to close devtools on browser toolbox closing. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d9ced82bc6d1
[devtools] Rename gDevTools._toolboxes to gDevTools._toolboxesPerCommands. r=nchevobbe

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ab24053acb84
https://hg.mozilla.org/mozilla-central/rev/d9ced82bc6d1

Comment 8

[Donal Meehan [:dmeehan]]

:ochameau looks like an annoying bug we should avoid shipping in 107. Could you consider adding a beta uplift request on this?

Comment 9

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 9300651 [details]
Bug 1797730 - [devtools] Fix typo preventing to close devtools on browser toolbox closing.

Beta/Release Uplift Approval Request

• User impact if declined: DevTools wouldn't close when closing firefox, when devtools are opened in independant windows
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Open any page then open devtools and ensure they are in an independant window

• close firefox browser window
  AR: firefox browser window is closed but not devtools
  ER: all windows are closed

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Missed renaming a variable whose name changed.
• String changes made/needed: no
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9300651 [details]
Bug 1797730 - [devtools] Fix typo preventing to close devtools on browser toolbox closing.

Approved for 107.0b9

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9300738 [details]
Bug 1797730 - [devtools] Rename gDevTools._toolboxes to gDevTools._toolboxesPerCommands.

Approved for 107.0b9

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/763681545da1
https://hg.mozilla.org/releases/mozilla-beta/rev/1420206098a6

Comment 13

[Alin Ilea, Desktop Test Engineering [pto until 01.09]]

Reproduced the issue in Beta 107.0b8 using Windows 10.
Verified - Fixed in Beta 107.0b9 and the latest Nightly 108.0a1 (build id: 20221103214316), using Windows 10, macOS 12 and Ubuntu 20. Developer Tools (open in Separate Window) closes when Firefox quits.