1797749 - [wpt-sync] Sync PR 36687 - Split up SAA tests, add test for basic permission states.

Status: RESOLVED INVALID

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36687 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36687
Details from upstream follow.

Johann Hofmann <[e-mail]> wrote:

Split up SAA tests, add test for basic permission states.

This removes the recurive monolithical single SAA test file in favor of
smaller ones. This helps test grant cases where we need to have both
user interaction and permission grants, which were extremely unreliable
with the larger test file.

Bug: 1378969, 1374277
Change-Id: Iebc9bd48185ff398181bf1a16c35995a2467cb54
Reviewed-on: https://chromium-review.googlesource.com/3986031
WPT-Export-Revision: 20a1532c847c0849c02ef57664079116baebc38c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36687 applied with additional changes from upstream: 5098f818e7fb02aa1c288b42085cc1b9dcda12cd, 72b8989a676d49507a16665ae534836d7121b9d1, 2b0e3c6158f6cf7d06937ed1010e1289fc4ef898, f9d5e9475ede2e2d0b0410c55c4b8618d7a4d9ef, d86be3e36f0b24ab0632c2135e39bfdaa0aa42af, 5738d0254a247e349e08b73c53c4685167453d5c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d11d349355af7fb0769a9a6b029cf55ea6ba13e

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 3 subtests

Status Summary

Firefox

OK : 6
PASS : 30
FAIL : 13
TIMEOUT: 4
NOTRUN : 3

Chrome

OK : 6
FAIL : 44
TIMEOUT: 1
ERROR : 2

Safari

OK : 8
PASS : 22
FAIL : 26

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html [wpt.fyi]: TIMEOUT

New Tests That Don't Pass

• /storage-access-api/hasStorageAccess-insecure.sub.window.html [wpt.fyi]
  • [top-level-context] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: FAIL)
  • [cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: PASS)
  • [same-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-same-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-cross-origin-frame] document.hasStorageAccess() should be disallowed in insecure contexts: FAIL (Chrome: FAIL, Safari: PASS)
• /storage-access-api/requestStorageAccess-cross-origin-iframe.sub.https.window.html [wpt.fyi]
  • [cross-origin-frame] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
  • [cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError without permission grant: FAIL (Chrome: FAIL, Safari: FAIL)
  • [cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError with denied permission: FAIL (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-insecure.sub.window.html [wpt.fyi]: TIMEOUT (Chrome: ERROR, Safari: OK)
  • [non-fully-active] document.requestStorageAccess() should reject when run in a detached frame: TIMEOUT (Chrome: FAIL, Safari: FAIL)
  • [non-fully-active] document.requestStorageAccess() should reject when run in a detached DOMParser document: NOTRUN (Chrome: FAIL, Safari: FAIL)
  • [top-level-context] document.requestStorageAccess() should be rejected when called with a user gesture in insecure context: NOTRUN (Chrome: TIMEOUT, Safari: FAIL)
• /storage-access-api/requestStorageAccess-nested-cross-origin-iframe.sub.https.window.html [wpt.fyi]
  • [nested-cross-origin-frame] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError without permission grant: FAIL (Chrome: FAIL, Safari: FAIL)
  • [nested-cross-origin-frame] document.requestStorageAccess() should be rejected with a NotAllowedError with denied permission: FAIL (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-nested-same-origin-iframe.sub.https.window.html [wpt.fyi]
  • [nested-same-origin-frame] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess-non-fully-active.sub.https.window.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached frame: TIMEOUT (Chrome: FAIL, Safari: FAIL)
  • [non-fully-active] document.requestStorageAccess() should not resolve when run in a detached DOMParser document: NOTRUN (Chrome: FAIL, Safari: FAIL)
• /storage-access-api/requestStorageAccess.sub.https.window.html [wpt.fyi]
  • [top-level-context] document.requestStorageAccess() should be resolved when called properly with a user gesture: FAIL (Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bda9f1290284
[wpt PR 36687] - Split up SAA tests, add test for basic permission states., a=testonly
https://hg.mozilla.org/integration/autoland/rev/0f9a054f6695
[wpt PR 36687] - Update wpt metadata, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bda9f1290284
https://hg.mozilla.org/mozilla-central/rev/0f9a054f6695