1797927 - Invalid freebusy query from Invite Attendees dialog when polish letter "ś" is in the input.

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Piotr]

Attachment: bug1.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

1. Create event
2. click "invite attendees"
3. enter "Ktoś Taki <[e-mail]>" (without quotes)

Actual results:

Free/busy info does not show,
a POST request is send with empty mailto: in ATTENDEE

BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
METHOD:REQUEST
BEGIN:VFREEBUSY
UID:4023247d-1e83-48b5-a51b-93ab7e537bdf
DTSTAMP:20221028T070831Z
DTSTART:20221028T060000Z
DTEND:20221113T070000Z
ORGANIZER:mailto:[e-mail]
ATTENDEE;PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICIPANT;CUTYPE=INDIVIDUAL:mailto:
END:VFREEBUSY
END:VCALENDAR

Attached are screenshots from debug in calendar-event-dialog-attendees.js, MailServices.headerParser.parseEncodedHeader returns object with "email" set to empty string for this input.

Expected results:

POST request with mailto: [e-mail] is send

BEGIN:VCALENDAR
(...)
ATTENDEE;PARTSTAT=NEEDS-ACTION;ROLE=REQ-PARTICIPANT;CUTYPE=INDIVIDUAL:mailto:[e-mail]
(...)
END:VCALENDAR

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1797927 - Invite attendees updateFreeBusy should form queries based on displayed email, not encoded header. r=#thunderbird-reviewers

The value is from user input, so should get the address using makeFromDisplayAddress (which never returns null.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67f9689bd808
Invite attendees updateFreeBusy should form queries based on displayed email, not encoded header. r=freaktechnik

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9301010 [details]
Bug 1797927 - Invite attendees updateFreeBusy should form queries based on displayed email, not encoded header. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): long time bug?
User impact if declined: free bust not necessarily working (if display name has encoding)
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): pretty safe

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9301010 [details]
Bug 1797927 - Invite attendees updateFreeBusy should form queries based on displayed email, not encoded header. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 107.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/b51e4d5d6cf5

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9301010 [details]
Bug 1797927 - Invite attendees updateFreeBusy should form queries based on displayed email, not encoded header. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.5.0:
https://hg.mozilla.org/releases/comm-esr102/rev/4579cf92ed69